[14.0][FIX] endpoint_route_handler: Use dedicated cursor for registry - #37
Merged
OCA-git-bot merged 1 commit intoJul 4, 2024
Merged
Conversation
Contributor
|
Hi @simahawk, |
grindtildeath
force-pushed
the
14.0-fix-endpoint_route_handler_cursor
branch
from
March 4, 2024 17:43
2a4cc86 to
2e89bc3
Compare
simahawk
requested changes
Mar 5, 2024
simahawk
left a comment
simahawk
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tracking down this issue :)
Contributor
|
One last bit: can you add the explanation as a comment? |
Contributor
|
I'll apply the changes |
simahawk
force-pushed
the
14.0-fix-endpoint_route_handler_cursor
branch
from
March 5, 2024 10:36
2e89bc3 to
3b91b2f
Compare
When the request cursor is used to instantiate the EndpointRegistry in the call to routing_map, the READ REPEATABLE isolation level will ensure that any value read from the DB afterwards, will be the same than when the first SELECT is executed. This is breaking the oauth flow as the oauth token that is written at the beggining of the oauth process cannot be read by the cursor computing the session token, which will read an old value. Therefore when the session security check is performed, the session token is outdated as the new session token is computed using an up to date cursor. By using a dedicated cursor to instantiate the EndpointRegistry, we ensure no read is performed on the database using the request cursor which will in turn use the updated value of the oauth token to compute the session token, and the security check will not fail.
simahawk
force-pushed
the
14.0-fix-endpoint_route_handler_cursor
branch
from
July 4, 2024 07:07
3b91b2f to
647787d
Compare
simahawk
self-requested a review
July 4, 2024 07:10
simahawk
approved these changes
Jul 4, 2024
simahawk
left a comment
simahawk
left a comment
Contributor
There was a problem hiding this comment.
Live on prod since 4 months.
Contributor
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 1aaec8f. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the request cursor is used to instantiate the EndpointRegistry in the call to routing_map, the READ REPEATABLE isolation level will ensure that any value read from the DB afterwards, will be the same than when the first SELECT is executed.
This is breaking the oauth flow as the oauth token that is written at the beginning of the oauth process cannot be read by the cursor computing the session token, which will read an old value. Therefore when the session security check is performed, the session token is outdated as the new session token is computed using an up to date cursor.
By using a dedicated cursor to instantiate the EndpointRegistry, we ensure no read is performed on the database using the request cursor which will in turn use the updated value of the oauth token to compute the session token, and the security check will not fail.