Skip to content

[16.0][ADD] webservice_server_env: make server_environment an optional dependency - #42

Closed
dreispt wants to merge 2 commits into
OCA:16.0from
ursais:16-dr-webservice_server_env
Closed

[16.0][ADD] webservice_server_env: make server_environment an optional dependency#42
dreispt wants to merge 2 commits into
OCA:16.0from
ursais:16-dr-webservice_server_env

Conversation

@dreispt

@dreispt dreispt commented Apr 28, 2024

Copy link
Copy Markdown
Member
  • [ADD] webservice_server_env: make server_environment an optional dependency
  • [REF] webservice: make server_environment an optional dependency

@OCA-git-bot

OCA-git-bot commented Apr 28, 2024

Copy link
Copy Markdown
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@dreispt
dreispt requested a review from simahawk April 28, 2024 10:44
@gurneyalex gurneyalex added this to the 16.0 milestone May 14, 2024
@gurneyalex gurneyalex mentioned this pull request Sep 5, 2024
Closed
@github-actions

github-actions Bot commented Sep 15, 2024

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024
@github-actions github-actions Bot closed this Oct 20, 2024
@simahawk simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 21, 2024
@simahawk simahawk reopened this Oct 21, 2024
@simahawk

simahawk commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

I still want to evaluate this

@github-actions

github-actions Bot commented Feb 23, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 23, 2025
@github-actions github-actions Bot closed this Mar 30, 2025
@dreispt dreispt reopened this Mar 30, 2025
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 6, 2025
@dreispt

dreispt commented Jun 15, 2025

Copy link
Copy Markdown
Member Author

Ping!

@dreispt dreispt changed the title [ADD] webservice_server_env: make server_environment an optional dependency [16.0][ADD] webservice_server_env: make server_environment an optional dependency Jun 15, 2025
@dreispt
dreispt force-pushed the 16-dr-webservice_server_env branch 3 times, most recently from c540f88 to a38e30b Compare June 15, 2025 12:40
@dreispt
dreispt requested a review from etobella June 15, 2025 12:42
@dreispt

dreispt commented Jun 15, 2025

Copy link
Copy Markdown
Member Author

Reworked, to accommodate later changes...

@dreispt
dreispt force-pushed the 16-dr-webservice_server_env branch 5 times, most recently from b208eae to ff8986a Compare June 15, 2025 13:12
@dreispt
dreispt force-pushed the 16-dr-webservice_server_env branch from ff8986a to 5be4024 Compare June 15, 2025 13:24
@dreispt dreispt mentioned this pull request Jun 15, 2025
Open
@github-actions

github-actions Bot commented Oct 19, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 19, 2025
@github-actions github-actions Bot closed this Nov 23, 2025
yankinmax
yankinmax reviewed Mar 23, 2026
View reviewed changes
Comment thread setup/webservice_server_env/odoo/addons/webservice_server_env
@@ -0,0 +1 @@
../../../../webservice_server_env No newline at end of file

@yankinmax yankinmax Mar 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose new line is missing here.

@yankinmax

yankinmax commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Hello @dreispt
We're going to push some effort to remove server_environment dependency on other storage modules as well.
Can you pls refresh this PR?
From my side I'll also take a chance to get more reviews so it can be merged very soon.

ivantodorovich
ivantodorovich reviewed Mar 23, 2026
View reviewed changes

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk Awaiting requested review from simahawk
@etobella etobella Awaiting requested review from etobella
2 more reviewers
@ivantodorovich ivantodorovich ivantodorovich left review comments
@yankinmax yankinmax yankinmax left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

6 participants

@dreispt @OCA-git-bot @simahawk @yankinmax @ivantodorovich @gurneyalex