[FIX] endpoint_route_handler: Rollback dedicated routing cursor - #77
Merged
Merged
Conversation
Contributor
|
Hi @simahawk, |
simahawk
reviewed
Dec 13, 2024
paradoxxxzero
force-pushed
the
16.0-fix-endpoint_route_handler
branch
from
December 13, 2024 15:39
19023b5 to
0190a5c
Compare
JordiMForgeFlow
approved these changes
Dec 17, 2024
Contributor
|
This PR has the |
lmignon
approved these changes
Dec 20, 2024
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
Thank you for the fix @paradoxxxzero LGTM
Contributor
|
/ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 137426b. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless I am missing something, we should not commit this transaction (
registry.cursor()commits at__exit__).This fix the failing tests in rest-framework: OCA/rest-framework#470