Skip to content

[11.0][ADD] web_tree_resize_column: Resize columns in tree views - #1151

Merged
pedrobaeza merged 1 commit into
OCA:11.0from
tarteo:11-resize-columns
Feb 14, 2019
Merged

[11.0][ADD] web_tree_resize_column: Resize columns in tree views#1151
pedrobaeza merged 1 commit into
OCA:11.0from
tarteo:11-resize-columns

Conversation

@tarteo

@tarteo tarteo commented Jan 9, 2019

Copy link
Copy Markdown
Member

With this module you can resize the columns of tree views including ones that are nested in form views.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Jan 9, 2019
Tardo
Tardo reviewed Jan 31, 2019
View reviewed changes
Comment thread web_tree_resize_column/static/lib/resizableColumns/jQuery.resizableColumns.js Outdated
Tardo
Tardo reviewed Feb 3, 2019
View reviewed changes
Comment thread web_tree_resize_column/static/src/js/backend.js
@Tardo

Tardo commented Feb 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

I have this issue when try resize the first time
issue

Firefox 65.0 - Linux

elicoidal
elicoidal approved these changes Feb 3, 2019
View reviewed changes

@elicoidal elicoidal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarteo

tarteo commented Feb 5, 2019

Copy link
Copy Markdown
Member Author

@Tardo Let me see if I can fix that.

@tarteo
[ADD] web_tree_resize_column
4caa8ad 
[FIX] Initial resizing
@tarteo
tarteo force-pushed the 11-resize-columns branch from a2db759 to 4caa8ad Compare February 5, 2019 10:59
@tarteo

tarteo commented Feb 5, 2019

Copy link
Copy Markdown
Member Author

@Tardo I fixed the issue in Firefox but it was an issue in the plugin. I'm gonna make a PR for that in the plugin's repository.

@Tardo

Tardo commented Feb 6, 2019

Copy link
Copy Markdown
Member

Yep, now works fine.

HaGuesto
HaGuesto reviewed Feb 8, 2019
View reviewed changes

@HaGuesto HaGuesto left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM nice feature!

Just as a comment before I approve:
Is it possible to add some kind of separating lines between the columns? Otherwise, one has to guess where one needs to click.

Before they were shown:
bildschirmfoto_2019-02-08_14-20-22

@tarteo

tarteo commented Feb 13, 2019

Copy link
Copy Markdown
Member Author

@HaGuesto I think the lines between the columns is enough, because when the line is hovered the cursor changes to the horizontal resize icon (col-resize)

@OCA-git-bot

OCA-git-bot commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza

pedrobaeza commented Feb 13, 2019

Copy link
Copy Markdown
Member

@Tardo waiting your validation for merging.

@pedrobaeza
pedrobaeza merged commit cd97a8d into OCA:11.0 Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tardo Tardo Tardo approved these changes
+2 more reviewers
@elicoidal elicoidal elicoidal approved these changes
@HaGuesto HaGuesto HaGuesto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved needs review ready to merge

Projects

None yet

Milestone

11.0

Development

Successfully merging this pull request may close these issues.

6 participants

@tarteo @Tardo @OCA-git-bot @pedrobaeza @elicoidal @HaGuesto