Skip to content

[IMP][11.0][web_responsive] Sticky Statusbar & List View Header-Footer - #973

Merged
guewen merged 2 commits into
OCA:11.0from
Tardo:sticky_toolbar
Jul 3, 2018
Merged

[IMP][11.0][web_responsive] Sticky Statusbar & List View Header-Footer#973
guewen merged 2 commits into
OCA:11.0from
Tardo:sticky_toolbar

Conversation

@Tardo

@Tardo Tardo commented Jun 30, 2018

Copy link
Copy Markdown
Member

sticky_statusbar

A) With Sticky Statusbar (PR)
B) Without Sticky Statusbar (Normal)

sticky_list

@Tardo Tardo changed the title [IMP] Sticky Statusbar [IMP][11.0][web_responsive] Sticky Statusbar Jun 30, 2018
@Tardo Tardo changed the title [IMP][11.0][web_responsive] Sticky Statusbar [IMP][11.0][web_responsive] Sticky Statusbar & List View Header-Footer Jul 1, 2018
@pedrobaeza pedrobaeza added this to the 11.0 milestone Jul 2, 2018
@pedrobaeza

Copy link
Copy Markdown
Member

Another great option!

Maybe you can check #540 for other suggestions I made some time ago.

@yajo yajo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! ❤️

>.table-responsive {
>.o_list_view {
thead {
position: sticky;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds this is not going to work for everybody https://caniuse.com/#search=sticky :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually CSS would ignore unknown rules and just leave the defaults, so that shouldn't be a problem in most cases.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, maybe worth to add it to known issue / roadmap?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's not known until you open a old browser and check it's broken.
Let's just expect it works, and if it breaks somebody, and that somebody cannot stop using IE, we'll fix it then. ☺️

@guewen guewen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@guewen
guewen merged commit b773d92 into OCA:11.0 Jul 3, 2018
@Tardo
Tardo deleted the sticky_toolbar branch July 3, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants