[10.0] [website_anchor_smooth_scroll] Smooth scroll link broken on images

[Kazebayashi]

Hi

I just installed website_anchor_smooth_scroll and website_snippet_anchor.
Since then smooth scroll is working very well on text links, but image links do not work anymore (nothing happen on click).

The link itself is exactly the same:
Image link:

<a href="#anchor1" data-original-title="" title="">
<img class="img img-responsive" src="/web/image/1222" alt="" data-original-title="" title="Image link"/>
</a>

And text link:

<a href="#anchor1" data-original-title="" title="">Text link</a>

The anchor is set to the section tag:

<section class="s_big_picture bg-gray-darker mt0" style="" id="anchor1">
[...]
</section>

The link works when I use the full address, like <a href="/page#anchor1"><img/></a> but then the smooth scrolling do not work.

Any idea how to solve it?
Thanks

[Kazebayashi]

I tried on runbot and get the same result.

[yajo]

Pretty dumb failure... All we have to do is change to event.currentTarget.hash here:

website/website_anchor_smooth_scroll/static/src/js/website_anchor_smooth_scroll.js

Line 14 in 28910f7

var anchor_fragment = event.target.hash;

Do you want to make the PR?

[Kazebayashi]

Thanks Yajo! It works perfectly well.

I did the PR (#412), but I hope I did it properly (I'm not a very experienced github user yet...).