Skip to content

[MIG] website_local_font: Migration to 16.0#1028

Closed
Reyes4711-S73 wants to merge 3 commits intoOCA:16.0from
Studio73:16.0-mig-website_local_fonts-new
Closed

[MIG] website_local_font: Migration to 16.0#1028
Reyes4711-S73 wants to merge 3 commits intoOCA:16.0from
Studio73:16.0-mig-website_local_fonts-new

Conversation

@Reyes4711-S73
Copy link

Standard migration to 16.0
Reopen from #999

bvanjeelharia and others added 2 commits January 9, 2024 07:46
[ADD] website_local_fonts: add new module

[ADD] website_local_fonts: add new module

Updated Test Folder Name

Changes as per suggestions in the PR

Added missing setup file
tarteo added a commit to onesteinbv/addons-oca that referenced this pull request Feb 6, 2024
),
],
"web.assets_backend": [
"website_local_font/static/src/xml/website.editor.xml",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this xml file to website.assets_wysiwyg asset instead of website_assets_backend? That way you don't need to define this in the snippets.options.js as xmldependency

Copy link

@ByteMeAsap ByteMeAsap Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snippets.options.js.txt
Modify the code as shared in the attached file. I have removed xmlDependencies, inherited the start method in a way that it can be inherited by other modules in future, removed widgetObj in _saveLocalFont function and replaced by this and made use of "const" instead of "var"

@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-mig-website_local_fonts-new branch 2 times, most recently from 2ce6be5 to 3ab6ef1 Compare February 28, 2024 10:33
@Reyes4711-S73
Copy link
Author

@ByteMeAsap I put your changes but, I tested in a local environment and in a runboat and I have this error.
image
When you modify the snippets.options.js, there are some errors in pre-commit. Please review it. I'm going to return to previous changes

@Reyes4711-S73 Reyes4711-S73 force-pushed the 16.0-mig-website_local_fonts-new branch from 3ab6ef1 to e9cad2a Compare February 28, 2024 11:46
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 30, 2024
@github-actions github-actions bot closed this Aug 4, 2024
@ioans73 ioans73 deleted the 16.0-mig-website_local_fonts-new branch August 5, 2024 05:54
Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants