Skip to content

[BP][IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality#1116

Open
NICO-SOLUTIONS wants to merge 1 commit intoOCA:14.0from
NICO-SOLUTIONS:14.0-bp-imp-website_cookiefirst_consent_js
Open

[BP][IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality#1116
NICO-SOLUTIONS wants to merge 1 commit intoOCA:14.0from
NICO-SOLUTIONS:14.0-bp-imp-website_cookiefirst_consent_js

Conversation

@NICO-SOLUTIONS
Copy link
Member

@NICO-SOLUTIONS NICO-SOLUTIONS commented Jul 2, 2025

@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review July 2, 2025 13:14
ioans73
ioans73 approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@ioans73 ioans73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NICO-SOLUTIONS
[IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality
5368132 
- replace banner.js with new consent.js script using domain and identifier
- remove www. prefix from domain in cookiefirst script URL
- back ported from V17 PR (OCA#1110 & OCA#1117)
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 14.0-bp-imp-website_cookiefirst_consent_js branch from ef79780 to 5368132 Compare July 10, 2025 10:01
mariancuadranetkia
mariancuadranetkia approved these changes Aug 20, 2025
View reviewed changes
Copy link

@mariancuadranetkia mariancuadranetkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 20, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions
Copy link

github-actions bot commented Mar 8, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 8, 2026
@NICO-SOLUTIONS
Copy link
Member Author

NICO-SOLUTIONS commented Mar 8, 2026

@pedrobaeza
hey pedro. Could you remove the stale tag pls? would be great..

@pedrobaeza pedrobaeza added this to the 14.0 milestone Mar 9, 2026
@pedrobaeza
Copy link
Member

pedrobaeza commented Mar 9, 2026

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 9, 2026

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1116-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 9, 2026
@OCA-git-bot
Merge PR #1116 into 14.0
db220d7 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 9, 2026

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1116-by-pedrobaeza-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ioans73 ioans73 ioans73 approved these changes

@miguel-S73 miguel-S73 miguel-S73 approved these changes

@mariancuadranetkia mariancuadranetkia mariancuadranetkia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

6 participants

@NICO-SOLUTIONS @OCA-git-bot @pedrobaeza @ioans73 @miguel-S73 @mariancuadranetkia