Closed
Conversation
Contributor
Author
|
SaSS now passes, leaving another error in its wake due to website_seo_redirection: |
Contributor
Author
|
Hahaha well crap I submitted to the wrong branch for merge and now Travis is mad confused, I'll submit another |
Member
|
You don't need to do that. Let me change it. |
Contributor
Author
|
You can change it in Travis? Too late now, but good to know for next time I'm dumb |
Member
|
I cannot reopen it, but see https://github.com/blog/2224-change-the-base-branch-of-a-pull-request |
Contributor
Author
|
I did that actually. Travis was still building on the 10.0 though 😦 |
Contributor
Author
|
Just so the note is in both places for future Googlers, trick to getting Travis to pick up the PR base change is to amend the commit so that it's considered different. Otherwise Travis is caching. |
matteoopenf
pushed a commit
to matteoopenf/website
that referenced
this pull request
Feb 17, 2023
* [11.0][NEW] website_sale_product_minimal_price: New module * [11.0][IMP] website_sale_product_minimal_price: Order by minimal variant price (from pricelists or extra variant price) [UPD] Update website_sale_product_minimal_price.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-11.0/e-commerce-11.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_product_minimal_price/ [UPD] README.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix to #282
Question still stands as to why this issue just popped up, and why it's not showing on v8 or v10.