fix: strip hash prefix from marker colors in URL construction#116
Closed
fix: strip hash prefix from marker colors in URL construction#116
Conversation
The old extension (OcapReplaySaver2) sends marker colors with a # prefix (e.g., #E60000), but the URL construction expected colors without it. The # character in URLs is interpreted as a fragment identifier by the browser, causing everything after it to be dropped and resulting in 404 errors for marker images. This strips the # prefix if present while maintaining backward compatibility with data that doesn't include the prefix.
1 task
fank
added a commit
that referenced
this pull request
Feb 22, 2026
Implements extension PR #116 on the web side. The extension now sends a single :TELEMETRY: command with FPS, per-side entity counts, global counts, running scripts, weather, and player network data instead of the old :FPS: command with just FPS values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#prefix (e.g.,#E60000), which the browser interprets as a URL fragment, dropping the color parameter#prefix if present while maintaining backward compatibilityTest plan
#prefix#) to verify backward compatibility