Skip to content

Improve pixel density logic in OcrdExif#257

Merged
kba merged 2 commits intoOCR-D:masterfrom
bertsky:exif-resolution
Jul 17, 2019
Merged

Improve pixel density logic in OcrdExif#257
kba merged 2 commits intoOCR-D:masterfrom
bertsky:exif-resolution

Conversation

@bertsky
Copy link
Collaborator

@bertsky bertsky commented Jul 11, 2019

@bertsky
Copy link
Collaborator Author

bertsky commented Jul 11, 2019

Looking into Travis failure now... (I get IFDRational instead of integer for xResolution, which is not allowed in the multiplication, at least in Python 3.5 3.4)

@bertsky
Copy link
Collaborator Author

bertsky commented Jul 11, 2019

It's strange that IFDRational would not be an allowed operand type for * in Python 3.5 3.4 and Python 3.7 ...

@bertsky
Copy link
Collaborator Author

bertsky commented Jul 11, 2019

The Python 3.7-dev test seems to broken already.

@kba
Copy link
Member

kba commented Jul 11, 2019

Yeah, the 3.7-dev failure is unrelated, though strange.

pytest.py: error: unrecognized arguments: --duration=10

Version problem with the tooling it seems.

@bertsky
Copy link
Collaborator Author

bertsky commented Jul 11, 2019

Python 3.4 has been removed from support in Pillow >= 6.0:

Drop support for Python 3.4 #3596 [hugovk]

But we get the issue with 5.4.1 according to Travis' log

@bertsky
Copy link
Collaborator Author

bertsky commented Jul 11, 2019

No GH issues for the IFDRational problem in Pillow yet. I will try the Pillow selftest in a 3.4 installation...

@kba
Copy link
Member

kba commented Jul 11, 2019

Or we just stop supporting 3.4. IIRC the reason we did support it was because of CentOS still shipping it a year ago. Development stopped, there will be no more 3.4 releases. @cneud @wrznr what do you think?

@codecov-io
Copy link

Codecov Report

Merging #257 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   99.45%   99.45%   +<.01%     
==========================================
  Files          30       30              
  Lines        1277     1279       +2     
  Branches      248      248              
==========================================
+ Hits         1270     1272       +2     
  Misses          6        6              
  Partials        1        1
Impacted Files Coverage Δ
ocrd_models/ocrd_models/ocrd_exif.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1782c56...6de707c. Read the comment docs.

@kba kba merged commit 9c828a8 into OCR-D:master Jul 17, 2019
@bertsky bertsky deleted the exif-resolution branch October 8, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants