Conversation
xuzhg
requested review from
ElizabethOkerio,
KenitoInc,
gathogojr,
habbes,
lisicase and
mikepizzo
January 31, 2023 02:54
gathogojr
reviewed
Jan 31, 2023
gathogojr
reviewed
Jan 31, 2023
|
|
||
| property = propertySegment.Property; | ||
| structuredType = GetStructuredType(propertySegment.Property.Type); | ||
| structuredType = propertySegment.Property.Type.ToStructuredType(); |
Contributor
There was a problem hiding this comment.
Is it possible to add a test to demonstrate that an exception is not thrown after this change?
Member
Author
There was a problem hiding this comment.
ToStructuredType is an extension method in ODL , this method is well-tested at ODL , the implementation doesn't throw exception.
julealgon
previously approved these changes
Jan 31, 2023
Member
Author
|
@gathogojr I'd like to merge it and move forward it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #829.