Make output set of $apply transformations available for subsequent transformations or other query operators - #987
Merged
ElizabethOkerio merged 2 commits intoJul 13, 2023
Conversation
gathogojr
reviewed
Jul 12, 2023
Contributor
|
@ElizabethOkerio For my understanding, how did this regression come about and how does the seemingly innocuous code change fix the issue? Can you add an explanation in the pull request description? |
gathogojr
reviewed
Jul 12, 2023
Contributor
|
@ElizabethOkerio Does this pull request fix this issue too? #984 |
ElizabethOkerio
added a commit
to ElizabethOkerio/AspNetCoreOData
that referenced
this pull request
Aug 8, 2023
…ansformations or other query operators (OData#987) * apply with orderby using dynamic props * u[pdate based on review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #945, #984
This fix makes this work:
Like you can use the output of $apply transformations,
Total, in this case to perform subsequent transformations,$orderbyin this case.This is how the
ApplyClauseproperty looks like:So what happens when this is called:
if (options.Apply?.ApplyClause != null). ifApplyClauseis null,which will be null at this point, then theParseApplygets called which parses the apply clause and binds the dynamic properties introduced in the$applytransformation. This makes these properties recognizable in subsequent transformations.Before this change, the parsing of the apply clause was not happening before the
$orderbygets called.