fix(sr): dcm4chee requires the patient name for an SR to match what is in the original study by jbocce · Pull Request #3739 · OHIF/Viewers

jbocce · 2023-10-20T18:57:13Z

Context

Fixes #3648

Changes & Results

Format the patient name of a measurement report as per DICOM.

Testing

See #3648

Checklist

PR

My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

OS: Windows 11
Node version: 18.16.1
Browser: Chrome 118.0.5993.71

… per DICOM.

netlify · 2023-10-20T18:57:19Z

✅ Deploy Preview for ohif-dev ready!

Name	Link
🔨 Latest commit	`8bc4345`
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/6537dc01b210c90008be642b
😎 Deploy Preview	https://deploy-preview-3739--ohif-dev.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-10-20T18:57:19Z

✅ Deploy Preview for ohif-platform-docs ready!

Name	Link
🔨 Latest commit	`8bc4345`
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/6537dc01cdda23000868c3c2
😎 Deploy Preview	https://deploy-preview-3739--ohif-platform-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sedghi · 2023-10-20T19:01:09Z

is this related to this too? dcmjs-org/dcmjs#364

codecov · 2023-10-20T19:06:00Z

Codecov Report

Merging #3739 (8bc4345) into master (8a335bd) will decrease coverage by 0.15%.
Report is 81 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3739      +/-   ##
==========================================
- Coverage   46.23%   46.09%   -0.15%     
==========================================
  Files          78       78              
  Lines        1276     1280       +4     
  Branches      312      312              
==========================================
  Hits          590      590              
- Misses        548      552       +4     
  Partials      138      138

Files	Coverage Δ
platform/core/src/utils/downloadCSVReport.js	`0.00% <ø> (ø)`
...ils/metadataProvider/getPixelSpacingInformation.js	`0.00% <0.00%> (ø)`
platform/core/src/log.js	`14.28% <0.00%> (-85.72%)`	⬇️
...services/DicomMetadataStore/createStudyMetadata.js	`0.00% <0.00%> (ø)`
...ervices/DicomMetadataStore/createSeriesMetadata.js	`0.00% <0.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbbcea...8bc4345. Read the comment docs.

jbocce · 2023-10-20T19:08:53Z

is this related to this too? dcmjs-org/dcmjs#364

Yes I would say just from the second comment it is related.

sedghi · 2023-10-20T20:19:46Z

@jbocce I mean does it makes sense to wait for dcmjs to update and we just consume a newer version?

jbocce · 2023-10-23T11:31:39Z

@jbocce I mean does it makes sense to wait for dcmjs to update and we just consume a newer version?

Yes I think that makes sense. However there is the slice thickness change in this PR that is still needed AND we should leave this PR open just in case the timing of the dcmjs fix is not favourable for any OHIF release. Does that make sense?

… for URL encoding the DICOM JSON URL.

…-to-dcm4chee

jbocce · 2023-10-24T15:03:09Z

platform/docs/docs/configuration/dataSources/dicom-json.md

 ![](../../assets/img/dicom-json-public.png)

+:::tip
+It is important to URL encode the `url` query parameter especially if the `url`


I added these docs for DICOM JSON for an unrelated issue that I recently closed.

* fix(cli): various fixes for adding custom modes and extensions (OHIF#3683) Co-authored-by: Alireza <ar.sedghi@gmail.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(no sab): should work when shared array buffer is not required (OHIF#3686) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(config): support more values for the useSharedArrayBuffer (OHIF#3688) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(StackSync): Miscellaneous fixes for stack image sync (OHIF#3663) * fix(dicom overlay): Handle special cases of ArrayBuffer for various DICOM overlay attributes. (OHIF#3684) Co-authored-by: Alireza <ar.sedghi@gmail.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(typescript error): Change pubSubServiceInterface file type to typescript (OHIF#3546) Co-authored-by: edward65 <edward@afxmedical.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(editing): regression bug in disable editing (OHIF#3687) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs(links): Adding references to two used markdown links (OHIF#3650) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(displayArea): add display area to hanging protocol (OHIF#3691) Co-authored-by: Ouwen Huang <ouwen.oh@gmail.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(debug): Add timing information about time to first image/all images, and query time (OHIF#3681) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cli): Add npm packaged mode not working (OHIF#3689) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(translation): Side panel translate fix (OHIF#3156) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(locale): Added Turkish language support (tr-TR) - Community PR (OHIF#3695) Co-authored-by: Ahmet Altay <46381367+ahmetaltay33@users.noreply.github.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(locale): add German translations - community PR (OHIF#3697) Co-authored-by: pwespi <pwespi@pm.me> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(measurement and microscopy): various small fixes for measurement and microscopy side panel (OHIF#3696) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation scroll): and hydration bugs (OHIF#3701) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(bugs): fixing lots of bugs regarding release candidate (OHIF#3700) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(Segmentation): download RTSS from Labelmap(OHIF#3692) Co-authored-by: Alireza <ar.sedghi@gmail.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation): do not use SAB if not specified (OHIF#3705) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(modality unit): fix the modality unit per target via upgrade of cs3d (OHIF#3706) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(voi): should publish voi change event on reset (OHIF#3707) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation): Various fixes for segmentation mode and other (OHIF#3709) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(modules): add stylus loader as an option to be uncommented (OHIF#3710) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(i18n): display set(s) are two words for English messages (OHIF#3711) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(export): wrong export for the tmtv RT function (OHIF#3715) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(display messages): broken after timings (OHIF#3719) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * chore(version): move to the next beta version [BUMP BETA] * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(calibration): No calibration popup caused by perhaps an unused code optimization for production builds (OHIF#3736) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cine): Use the frame rate specified in DICOM and optionally auto play cine (OHIF#3735) Co-authored-by: rareramos <rareramos1126@gmail.com> Co-authored-by: Doug Horner <horner@mieweb.com> Co-authored-by: Rehan <58819707+Rayhan-011@users.noreply.github.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(recipes): package.json script orthanc:up docker-compose path (OHIF#3741) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs(azure): Azure static Deployment details (OHIF#3740) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(sr): dcm4chee requires the patient name for an SR to match what is in the original study (OHIF#3739) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(toolbar): allow customizable toolbar for active viewport and allow active tool to be deactivated via a click (OHIF#3608) Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(measurement service): Implemented correct check of schema keys in _isValidMeasurment. (OHIF#3750) * feat(filters): save worklist query filters to session storage so that they persist between navigation to the viewer and back (OHIF#3749) Co-authored-by: ladeirarodolfo <39910206+ladeirarodolfo@users.noreply.github.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(i18n): enhanced i18n support (OHIF#3730) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(thumbnail): Avoid multiple promise creations for thumbnails (OHIF#3756) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs(faq): FAQ and Segmentation Mode Fix for some studies (OHIF#3762) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(hp callback): Add viewport ready callback (OHIF#3772) Co-authored-by: Ouwen Huang <ouwen.huang@duke.edu> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat: add VolumeViewport rotation (OHIF#3776) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(arrow): ArrowAnnotate text key cause validation error (OHIF#3771) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(path): upgrade docusaurus for security (OHIF#3780) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(dicomJSON): Add Loading Other Display Sets and JSON Metadata Generation script (OHIF#3777) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(overlay): Overlays aren't shown on undefined origin (OHIF#3781) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: 🐛 Run error handler for failed image requests (OHIF#3773) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(url): Add SeriesInstanceUIDs wado query param (OHIF#3746) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(docs): Added various training videos to support the OHIF CLI tools (OHIF#3794) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(metadata): to handle cornerstone3D update for htj2k (OHIF#3783) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(DICOM Overlay): The overlay data wasn't being refreshed on change (OHIF#3793) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(events): broadcast series summary metadata (OHIF#3798) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat: Merge Data Source (OHIF#3788) Add the ability to merge two different series queries to generate a complete study query result. Provides basic support for other types of merges, but those aren't yet added as full features. * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: Update the CS3D packages to add the most recent HTJ2K TSUIDS (OHIF#3806) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cine): Set cine disabled on mode exit. (OHIF#3812) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(SM): drag and drop is now fixed for SM (OHIF#3813) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(auth): fix the issue with oauth at a non root path (OHIF#3840) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(HP): Added new 3D hanging protocols to be used in the new layout selector (OHIF#3844) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(i18n): enhanced i18n support (OHIF#3761) * fix: address and improve system vulnerabilities (OHIF#3851) * feat(config): Add activateViewportBeforeInteraction parameter for viewport interaction customization (OHIF#3847) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(customizationService): Enable saving and loading of private tags in SRs (OHIF#3842) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * Fix(HPService): custom image load performed is now reset to false on HP exit (OHIF#3809) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(dicom-seg) : Fix the missing color tag when loading Dicom-Seg (OHIF#3822) Co-authored-by: Alireza <ar.sedghi@gmail.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs: Update HangingProtocolService.md doc sameAs example to contain constr… (OHIF#3765) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(overlay): add inline binary overlays (OHIF#3852) * fix(icon-style): Ensure consistent icon dimensions (OHIF#3727) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * chore(version): upgrade cornerstone3D versions (OHIF#3853) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * chore(version): upgrade cornerstone3D versions to fix orientation (OHIF#3854) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] --------- Co-authored-by: Joe Boccanfuso <109477394+jbocce@users.noreply.github.com> Co-authored-by: Alireza <ar.sedghi@gmail.com> Co-authored-by: ohif-bot <danny.ri.brown+ohif-bot@gmail.com> Co-authored-by: Bill Wallace <wayfarer3130@gmail.com> Co-authored-by: Edward Son <edward_son@live.com> Co-authored-by: edward65 <edward@afxmedical.com> Co-authored-by: rodrigobasilio2022 <114958722+rodrigobasilio2022@users.noreply.github.com> Co-authored-by: Yaroslav Halchenko <debian@onerussian.com> Co-authored-by: Ouwen Huang <ouwen.oh@gmail.com> Co-authored-by: wangxuan <wx_0322@163.com> Co-authored-by: Ahmet Altay <46381367+ahmetaltay33@users.noreply.github.com> Co-authored-by: pwespi <pwespi@pm.me> Co-authored-by: dxlin <dxlin@users.noreply.github.com> Co-authored-by: rareramos <rareramos1126@gmail.com> Co-authored-by: Doug Horner <horner@mieweb.com> Co-authored-by: Rehan <58819707+Rayhan-011@users.noreply.github.com> Co-authored-by: edwardyangxin <yx_yoyo@live.cn> Co-authored-by: bluesteel23 <132684122+bluesteel23@users.noreply.github.com> Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com> Co-authored-by: ladeirarodolfo <39910206+ladeirarodolfo@users.noreply.github.com> Co-authored-by: Pavel <P.A.Pisarev@yandex.ru> Co-authored-by: Ouwen Huang <ouwen.huang@duke.edu> Co-authored-by: Pedro H. Köhler <pedrokohlerbh@gmail.com> Co-authored-by: Igor Octaviano <igoroctaviano@gmail.com> Co-authored-by: Sofien-Sellami <73444179+Sofien-Sellami@users.noreply.github.com> Co-authored-by: Salim Kanoun <salim.kanoun@gmail.com> Co-authored-by: Celian-abd <101793092+Celian-abd@users.noreply.github.com>

* chore(version): Update package versions [skip ci] * feat(displayArea): add display area to hanging protocol (OHIF#3691) Co-authored-by: Ouwen Huang <ouwen.oh@gmail.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(debug): Add timing information about time to first image/all images, and query time (OHIF#3681) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cli): Add npm packaged mode not working (OHIF#3689) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(translation): Side panel translate fix (OHIF#3156) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(locale): Added Turkish language support (tr-TR) - Community PR (OHIF#3695) Co-authored-by: Ahmet Altay <46381367+ahmetaltay33@users.noreply.github.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(locale): add German translations - community PR (OHIF#3697) Co-authored-by: pwespi <pwespi@pm.me> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(measurement and microscopy): various small fixes for measurement and microscopy side panel (OHIF#3696) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation scroll): and hydration bugs (OHIF#3701) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(bugs): fixing lots of bugs regarding release candidate (OHIF#3700) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(Segmentation): download RTSS from Labelmap(OHIF#3692) Co-authored-by: Alireza <ar.sedghi@gmail.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation): do not use SAB if not specified (OHIF#3705) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(modality unit): fix the modality unit per target via upgrade of cs3d (OHIF#3706) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(voi): should publish voi change event on reset (OHIF#3707) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation): Various fixes for segmentation mode and other (OHIF#3709) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(modules): add stylus loader as an option to be uncommented (OHIF#3710) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(i18n): display set(s) are two words for English messages (OHIF#3711) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(export): wrong export for the tmtv RT function (OHIF#3715) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(display messages): broken after timings (OHIF#3719) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * chore(version): move to the next beta version [BUMP BETA] * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(calibration): No calibration popup caused by perhaps an unused code optimization for production builds (OHIF#3736) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cine): Use the frame rate specified in DICOM and optionally auto play cine (OHIF#3735) Co-authored-by: rareramos <rareramos1126@gmail.com> Co-authored-by: Doug Horner <horner@mieweb.com> Co-authored-by: Rehan <58819707+Rayhan-011@users.noreply.github.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(recipes): package.json script orthanc:up docker-compose path (OHIF#3741) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs(azure): Azure static Deployment details (OHIF#3740) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(sr): dcm4chee requires the patient name for an SR to match what is in the original study (OHIF#3739) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(toolbar): allow customizable toolbar for active viewport and allow active tool to be deactivated via a click (OHIF#3608) Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(measurement service): Implemented correct check of schema keys in _isValidMeasurment. (OHIF#3750) * feat(filters): save worklist query filters to session storage so that they persist between navigation to the viewer and back (OHIF#3749) Co-authored-by: ladeirarodolfo <39910206+ladeirarodolfo@users.noreply.github.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(i18n): enhanced i18n support (OHIF#3730) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(thumbnail): Avoid multiple promise creations for thumbnails (OHIF#3756) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs(faq): FAQ and Segmentation Mode Fix for some studies (OHIF#3762) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(hp callback): Add viewport ready callback (OHIF#3772) Co-authored-by: Ouwen Huang <ouwen.huang@duke.edu> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat: add VolumeViewport rotation (OHIF#3776) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(arrow): ArrowAnnotate text key cause validation error (OHIF#3771) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(path): upgrade docusaurus for security (OHIF#3780) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(dicomJSON): Add Loading Other Display Sets and JSON Metadata Generation script (OHIF#3777) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(overlay): Overlays aren't shown on undefined origin (OHIF#3781) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: 🐛 Run error handler for failed image requests (OHIF#3773) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(url): Add SeriesInstanceUIDs wado query param (OHIF#3746) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(docs): Added various training videos to support the OHIF CLI tools (OHIF#3794) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(metadata): to handle cornerstone3D update for htj2k (OHIF#3783) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(DICOM Overlay): The overlay data wasn't being refreshed on change (OHIF#3793) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(events): broadcast series summary metadata (OHIF#3798) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat: Merge Data Source (OHIF#3788) Add the ability to merge two different series queries to generate a complete study query result. Provides basic support for other types of merges, but those aren't yet added as full features. * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: Update the CS3D packages to add the most recent HTJ2K TSUIDS (OHIF#3806) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cine): Set cine disabled on mode exit. (OHIF#3812) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(SM): drag and drop is now fixed for SM (OHIF#3813) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(auth): fix the issue with oauth at a non root path (OHIF#3840) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(HP): Added new 3D hanging protocols to be used in the new layout selector (OHIF#3844) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(i18n): enhanced i18n support (OHIF#3761) * fix: address and improve system vulnerabilities (OHIF#3851) * feat(config): Add activateViewportBeforeInteraction parameter for viewport interaction customization (OHIF#3847) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(customizationService): Enable saving and loading of private tags in SRs (OHIF#3842) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * Fix(HPService): custom image load performed is now reset to false on HP exit (OHIF#3809) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(dicom-seg) : Fix the missing color tag when loading Dicom-Seg (OHIF#3822) Co-authored-by: Alireza <ar.sedghi@gmail.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs: Update HangingProtocolService.md doc sameAs example to contain constr… (OHIF#3765) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(overlay): add inline binary overlays (OHIF#3852) * fix(icon-style): Ensure consistent icon dimensions (OHIF#3727) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * chore(version): upgrade cornerstone3D versions (OHIF#3853) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * chore(version): upgrade cornerstone3D versions to fix orientation (OHIF#3854) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: colormap for stack viewports via HangingProtocol (OHIF#3866) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: convert radian to degree value for mip rotation (OHIF#3881) * fix: PDF display request in v3 (OHIF#3878) Co-authored-by: Alireza <ar.sedghi@gmail.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat: improve disableEditing flag (OHIF#3875) Co-authored-by: Igor Octaviano <igoroctaviano@gmail.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(ui): sidePanel expandedWidth (OHIF#3728) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat: Add on mode init hook (OHIF#3882) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs: Update user-account-control.md (OHIF#3877) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation): upgrade cs3d to fix various segmentation bugs (OHIF#3885) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(transferSyntax): prefer server transcoded transfer syntax for all images (OHIF#3883) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(hp): enable OHIF to run with partial metadata for large studies at the cost of less effective hanging protocol (OHIF#3804) Co-authored-by: rodrigobasilio2022 <rodrigo.basilio@radicalimaging.com> Co-authored-by: rodrigobasilio2022 <114958722+rodrigobasilio2022@users.noreply.github.com> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: Update CS3D to fix second render (OHIF#3892) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs: Update architecture.md (OHIF#3891) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: 🐛 Check merge key for merge data source (OHIF#3901) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: is same orientaiton (OHIF#3905) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(viewport-sync): remember synced viewports bw stack and volume and RENAME StackImageSync to ImageSliceSync (OHIF#3849) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: catch errors in getPTImageIdInstanceMetadata (OHIF#3897) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix toggleHpTools to support split primary button (OHIF#3900) Fixes a small bug in toggling buttons with hanging protocols. * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: 🐛 Sort merge results based on default data source (input) (OHIF#3903) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(errorboundary): format stack trace properly (OHIF#3931) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(resize): Optimize resizing process and maintain zoom level (OHIF#3889) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(demo): Deploy issue (OHIF#3951) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(docs): Minor typos in hpModule.md (OHIF#3962) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs: Typo (OHIF#3975) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cli): mode creation template (OHIF#3876) (OHIF#3981) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(delete measurement): icon for measurement table (OHIF#3775) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(SR display): and the token based navigation (OHIF#3995) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(worklist): New worklist buttons and tooltips (OHIF#3989) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] --------- Co-authored-by: ohif-bot <danny.ri.brown+ohif-bot@gmail.com> Co-authored-by: Alireza <ar.sedghi@gmail.com> Co-authored-by: Ouwen Huang <ouwen.oh@gmail.com> Co-authored-by: Bill Wallace <wayfarer3130@gmail.com> Co-authored-by: Joe Boccanfuso <109477394+jbocce@users.noreply.github.com> Co-authored-by: wangxuan <wx_0322@163.com> Co-authored-by: Ahmet Altay <46381367+ahmetaltay33@users.noreply.github.com> Co-authored-by: pwespi <pwespi@pm.me> Co-authored-by: dxlin <dxlin@users.noreply.github.com> Co-authored-by: rareramos <rareramos1126@gmail.com> Co-authored-by: Doug Horner <horner@mieweb.com> Co-authored-by: Rehan <58819707+Rayhan-011@users.noreply.github.com> Co-authored-by: edwardyangxin <yx_yoyo@live.cn> Co-authored-by: bluesteel23 <132684122+bluesteel23@users.noreply.github.com> Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com> Co-authored-by: ladeirarodolfo <39910206+ladeirarodolfo@users.noreply.github.com> Co-authored-by: Pavel <P.A.Pisarev@yandex.ru> Co-authored-by: Ouwen Huang <ouwen.huang@duke.edu> Co-authored-by: Pedro H. Köhler <pedrokohlerbh@gmail.com> Co-authored-by: Igor Octaviano <igoroctaviano@gmail.com> Co-authored-by: Sofien-Sellami <73444179+Sofien-Sellami@users.noreply.github.com> Co-authored-by: Salim Kanoun <salim.kanoun@gmail.com> Co-authored-by: Celian-abd <101793092+Celian-abd@users.noreply.github.com> Co-authored-by: AbishekBista9 <133620692+AbishekBista9@users.noreply.github.com> Co-authored-by: rodrigobasilio2022 <rodrigo.basilio@radicalimaging.com> Co-authored-by: rodrigobasilio2022 <114958722+rodrigobasilio2022@users.noreply.github.com> Co-authored-by: Ibrahim <93064150+IbrahimCSAE@users.noreply.github.com> Co-authored-by: EricB <eric.brayet@free.fr> Co-authored-by: EricB <ericb@paire.tech>

…s in the original study (OHIF#3739)

fix(measurements): Format the patient name of a measurement report as…

988e539

… per DICOM.

jbocce requested a review from sedghi October 20, 2023 18:57

jbocce self-assigned this Oct 20, 2023

pieper mentioned this pull request Oct 23, 2023

fix(exports): interpret PN tags as union between object and string dcmjs-org/dcmjs#364

Merged

jbocce added 2 commits October 24, 2023 10:52

Fix for PatientName when exporting SR imported from dcmjs. Added docs…

add2faa

… for URL encoding the DICOM JSON URL.

Merge remote-tracking branch 'upstream/master' into fix/saving-report…

8bc4345

…-to-dcm4chee

jbocce commented Oct 24, 2023

View reviewed changes

sedghi approved these changes Oct 24, 2023

View reviewed changes

sedghi changed the title ~~fix(measurements): dcm4chee requires the patient name for an SR to match what is in the original study~~ fix(sr): dcm4chee requires the patient name for an SR to match what is in the original study Oct 24, 2023

sedghi merged commit d98439f into OHIF:master Oct 24, 2023

thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024

fix(sr): dcm4chee requires the patient name for an SR to match what i…

d690456

…s in the original study (OHIF#3739)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(sr): dcm4chee requires the patient name for an SR to match what is in the original study#3739

fix(sr): dcm4chee requires the patient name for an SR to match what is in the original study#3739
sedghi merged 3 commits intoOHIF:masterfrom
jbocce:fix/saving-report-to-dcm4chee

jbocce commented Oct 20, 2023

Uh oh!

netlify bot commented Oct 20, 2023 •

edited

Loading

Uh oh!

netlify bot commented Oct 20, 2023 •

edited

Loading

Uh oh!

sedghi commented Oct 20, 2023

Uh oh!

codecov bot commented Oct 20, 2023 •

edited

Loading

Uh oh!

jbocce commented Oct 20, 2023

Uh oh!

sedghi commented Oct 20, 2023

Uh oh!

jbocce commented Oct 23, 2023

Uh oh!

jbocce Oct 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jbocce commented Oct 20, 2023

Context

Changes & Results

Testing

Checklist

PR

Code

Public Documentation Updates

Tested Environment

Uh oh!

netlify bot commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for ohif-dev ready!

Uh oh!

netlify bot commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for ohif-platform-docs ready!

Uh oh!

sedghi commented Oct 20, 2023

Uh oh!

codecov bot commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jbocce commented Oct 20, 2023

Uh oh!

sedghi commented Oct 20, 2023

Uh oh!

jbocce commented Oct 23, 2023

Uh oh!

jbocce Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Oct 20, 2023 •

edited

Loading

netlify bot commented Oct 20, 2023 •

edited

Loading

codecov bot commented Oct 20, 2023 •

edited

Loading