Restore WoT coverage and docs - #4172
Merged
marcschier merged 18 commits intoAug 4, 2026
Merged
Conversation
Restore the NodeSet comparer tests and targeted WoT coverage that were dropped when the large branch was split. Refresh the related package and sample documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9e6a5abf-3299-4cd1-9855-010fedbf0ad8
marcschier
commented
Aug 3, 2026
marcschier
marked this pull request as ready for review
August 3, 2026 10:19
marcschier
marked this pull request as draft
August 3, 2026 10:38
marcschier
marked this pull request as ready for review
August 3, 2026 10:41
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores previously dropped WoT-related test coverage and refreshes documentation/readme content for WoT Connectivity and source generation packages/samples.
Changes:
- Re-adds WoT
NodeSetComparertest suites and restores coverage assertions in WoT/DI test projects. - Updates/extends NuGet READMEs for the source generator and WoT Connectivity server packages.
- Refreshes the WoT Connectivity sample README (commands/paths) and clarifies the
WotManagementAccessPolicyXML doc comment.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Opc.Ua.SourceGeneration/NugetREADME.md | Restores NuGet README for the source generator package. |
| tests/Opc.Ua.WotCon.Tests/Hosting/OpcUaWotConBuilderTests.cs | Restores a DI guard test around LazyConnect/AddClient registration. |
| tests/Opc.Ua.Types.Tests/Wot/NodeSetComparerTests.cs | Restores core WoT NodeSet comparer tests (equivalence, normalization, depth guard, roundtrip). |
| tests/Opc.Ua.Types.Tests/Wot/NodeSetComparerAdditionalTests.cs | Adds additional comparer tests for difference reporting, null guards, BOM handling, envelope roundtrip. |
| tests/Opc.Ua.Di.Tests/DeviceBuilderTests.cs | Restores assertions around complete nameplate writes and well-known functional group creation. |
| src/Opc.Ua.WotCon.Server/WotManagementAccessPolicy.cs | Clarifies documentation for minimum channel security expectations. |
| src/Opc.Ua.WotCon.Server/NugetREADME.md | Extends package README and updates documentation links. |
| samples/WotCon/README.md | Updates sample commands/paths and related documentation references. |
…e' into marcschier/wot-19-coverage
marcschier
changed the base branch from
marcschier/wot-16-samples
to
marcschier/wot-18-registry-bridge
August 3, 2026 10:54
Normalize WoT sample paths for case-sensitive systems and replace NuGet package README repo-relative documentation links with the established absolute GitHub URL convention. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9e6a5abf-3299-4cd1-9855-010fedbf0ad8
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
…e' into marcschier/wot-19-coverage
marcschier
merged commit Aug 4, 2026
7097de0
into
marcschier/wot-18-registry-bridge
49 of 186 checks passed
marcschier
added a commit
that referenced
this pull request
Aug 5, 2026
…ation, Server and xRegistry work it builds on (#4128) ## Summary Adds OPC UA WoT Connectivity 1.1 to the stack, together with the Types, source generation, Server and xRegistry work it is built on. This branch is the merge point for the fourteen-PR stack that replaced integration PR #4093; every constituent PR was reviewed and approved separately and is listed below. 414 files changed, +108,936 / -3,199. Roughly 46k added lines of product code, 57k of tests, plus samples, tools and documentation. ## Types - Complete `ExtensionObject` raw-body decoding for binary, XML and JSON bodies by resolving the concrete type through the message context's encodeable factory, and simplify the `Variant` structure helpers by delegating to it (#4128). - Add `IAtomicFileReplace` as an optional `IFileSystem` capability so existing external implementations keep working, with atomic publish for `LocalFileSystem` via `File.Replace`/`File.Move` and for `VirtualFileSystem` by re-keying the in-memory entry (#4128). - Add lossless conversion between WoT documents and NodeSet2 (`Opc.Ua.Wot.WotNodeSetConverter`). A byte-exact `uav:nodeSet` envelope is preserved when requested, the structured `uav:nodes` projection is used when the readable vocabulary is incomplete, and NodeSet2 is otherwise synthesized from readable WoT terms. Unmapped JSON members survive a round trip as pointer-addressed residue (#4131). ## Source generation - Improve the NodeSet to ModelDesign conversion and the generated node state (#4132). - Generate OPC UA models directly from WoT Thing Description files (#4134). ## Server - Add live NodeManager shadow and immediate reload. A reload materializes a new generation beside the active one and switches atomically; the superseded generation is retired gracefully so existing MonitoredItems keep being served until they drain, or immediately when the caller asks for it. Includes the request admission and drain machinery that lets an orderly shutdown wait for admitted requests instead of tearing down underneath them (#4147). - Make subscription transfer between sessions transactional, so a failed transfer leaves neither session holding a partially moved subscription (#4150). ## xRegistry - Allow clients to use explicit registry roots rather than assuming a well-known location (#4130). ## WoT Connectivity - Add the WoT Connectivity 1.1 information model: a registry-first revision layered on the abstract xRegistry base model, incorporating the complete published OPC 10100-1 v1.02 surface as deprecated nodes in the same namespace so existing 1.02 clients keep working (#4139). - Add the protocol binding abstractions and planners that compile WoT forms into executable plans (#4140). - Add the HTTP, Modbus, OPC UA and MQTT binding executors (#4144). - Add the registry and its stores, including document versioning, validation, dependency resolution and refresh (#4146). - Add the registry client (#4142). - Materialize WoT Thing Descriptions into the server address space, deriving types from Thing Models and instances from Thing Descriptions (#4154). - Restore the WoT asset registry bridge so the deprecated 1.02 asset surface is backed by the registry (#4171). - Add the WoT Connectivity samples and complete the documentation (#4156), and restore the remaining coverage and docs (#4172). ## New projects `src/Opc.Ua.WotCon.Bindings`, `src/Opc.Ua.WotCon.Bindings.Mqtt`, `tests/Opc.Ua.WotCon.Bindings.Tests`, `tests/Opc.Ua.WotCon.Samples.Tests`, and the `samples/WotCon` AggregationServer, AggregationClient and FlatTagServer samples. ## Constituent pull requests Merged into this branch top-down, each independently approved: | PR | Title | | --- | --- | | #4128 | [Types] Complete ExtensionObject decoding and add an atomic file replace capability | | #4131 | [Types] Add lossless conversion between WoT documents and NodeSet2 | | #4132 | [SourceGeneration] Improve NodeSet to ModelDesign conversion and generated node state | | #4134 | [SourceGeneration] Generate OPC UA models from WoT Thing Description files | | #4147 | [Server] Add live NodeManager shadow and immediate reload | | #4150 | [Server] Make subscription transfer between sessions transactional | | #4130 | [XRegistry] Allow clients to use explicit registry roots | | #4139 | [WotCon] Add the WoT Connectivity 1.1 information model | | #4140 | [WotCon] Add the WoT protocol binding abstractions and planners | | #4144 | [WotCon] Add the HTTP, Modbus, OPC UA and MQTT binding executors | | #4146 | [WotCon] Add the WoT Connectivity registry and its stores | | #4142 | [WotCon] Add the WoT Connectivity registry client | | #4154 | [WotCon] Materialize WoT Thing Descriptions into the server address space | | #4156 | [WotCon] Add the WoT Connectivity samples and complete the documentation | | #4171 | Restore WoT asset registry bridge | | #4172 | Restore WoT coverage and docs | Supersedes #4093. ## Follow-up The WoT Connectivity and WoT Binding drafts have moved to 1.1-draft2 since this work was authored. Aligning with that revision - the removed group vocabulary, the new projection/View construct, the remaining model vocabulary terms and the two new portable-identity validation rules - is tracked separately and will follow in its own pull request. ## Validation Built for every target framework with zero warnings and zero errors, and validated at the tip of the stack with `Opc.Ua.WotCon.Tests` at 999 passed / 0 failed and `Opc.Ua.Server.Tests` at 4024 passed / 0 failed. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9e6a5abf-3299-4cd1-9855-010fedbf0ad8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restored vs skipped
tests\Opc.Ua.Types.Tests\Wot\NodeSetComparerTests.cs: restored 7 tests.tests\Opc.Ua.Types.Tests\Wot\NodeSetComparerAdditionalTests.cs: restored 10 tests.tools\Opc.Ua.SourceGeneration\NugetREADME.md: restored, with wrapped links.tests\Opc.Ua.Di.Tests\DeviceBuilderTests.cs: restored complete-nameplate and well-known functional-group assertions.tests\Opc.Ua.WotCon.Tests\Hosting\OpcUaWotConBuilderTests.cs: restored lazy-connect AddClient guard. Skipped old server-feature registration assertion because DI registration changed to explicit interface registrations.tests\Opc.Ua.SourceGeneration.Tests\ModelGeneratorTests.cs: skipped; reference-only differences are obsolete generator harness/input helper changes and old naming assumptions.tests\Opc.Ua.WotCon.Tests\WotConnectivityNodeManagerTests.cs: skipped legacy RegistryBridge mirroring test; that API no longer exists.tests\Opc.Ua.Types.Tests\Wot\WotNativeProjectionErrorTests.cs: skipped old string-splice setup; current JsonNode-based test covers the same malformed-extension diagnostic.tests\Opc.Ua.WotCon.Tests\Registry\WotBlobResourceStoreTests.cs: skipped retired IAtomicFileReplace assertions; current tests cover IFileSystem.Replace and the blob size guard.tests\Opc.Ua.Server.Tests\SubscriptionTests.cs: skipped private-reflection enqueue helper; current test-only enqueue API is the intended behaviour.tests\Opc.Ua.Aot.Tests\HostingAotTests.cs: skipped formatting-only reference differences.docs\WotConnectivity.md,docs\WotBindings.md,samples\WotCon\README.md,docs\SourceGeneratedDataTypes.md, andtools\Opc.Ua.SourceGeneration\readme.md.Validation
dotnet test tests\Opc.Ua.Types.Tests\Opc.Ua.Types.Tests.csproj -c Release -p:CustomTestTarget=net10.0: 0 failed, 8447 passed (before 8430, after 8447).dotnet test tests\Opc.Ua.WotCon.Tests\Opc.Ua.WotCon.Tests.csproj -c Release -p:CustomTestTarget=net10.0: 0 failed, 978 passed (before 977, after 978).dotnet test tests\Opc.Ua.Di.Tests\Opc.Ua.Di.Tests.csproj -c Release -p:CustomTestTarget=net10.0: 0 failed, 371 passed, 1 skipped (before 369 passed/1 skipped, after 371 passed/1 skipped).dotnet test tests\Opc.Ua.SourceGeneration.Tests\Opc.Ua.SourceGeneration.Tests.csproj -c Release -p:CustomTestTarget=net10.0: 0 failed, 127 passed (before/after 127).dotnet test tests\Opc.Ua.Server.Tests\Opc.Ua.Server.Tests.csproj -c Release -p:CustomTestTarget=net10.0: rerun passed, 0 failed, 4017 passed, 8 skipped (before/after 4017 passed/8 skipped).dotnet build tests\Opc.Ua.Aot.Tests\Opc.Ua.Aot.Tests.csproj -c Release -v:m: succeeded, 0 warnings, 0 errors.