P1673: LWG review (follow-on to PR 424)#426
Merged
Merged
Conversation
Make "may alias" a transitive verb phrase, and put all such wording expressions in the form "Output may alias Input."
Make sure all Effects-equivalent-to that use the execution policy use `std::forward<ExecutionPolicy>(exec)`, instead of passing `exec` directly.
For `symmetric_matrix_rank_k_update` and `hermitian_matrix_rank_k_update`, rename the template parameter `InMat1` to `InMat`, because there's no `InMat2`. Fix this in the synopsis as well.
For in-place triangular_matrix_left_product and triangular_matrix_right_product, rename template parameter InMat1 to InMat.
Remove any wording (e.g., for `transposed`) that depends on P2642 (padded mdspan layouts). We can restore and correct that wording later.
Fix [linalg.algs.reqs] 1 by changing "type requirements" to "Constraints."
Add the Constraint that ExecutionPolicy is an execution policy.
Remove the requirement that the algorithms that take `ExecutionPolicy`
are parallel algorithms, because that would be circular with
**[algorithms.parallel]** 2 ("A _parallel algorithm_ is
a function template listed in this document
with a template parameter named `ExecutionPolicy`").
e.g., return type of required_span_size(), and formatting
Make `layout_blas_packed::mapping::operator()` take exactly two parameters, rather than a pack.
Key phrases: * "Since the triangular matrix is on the left" * "Since the triangular matrix is on the right"
For default `BinaryDivideOp`, replace lambda with `divides<void>{}`.
Add definitions of the "rows" and "columns" of a matrix to [linalg.general], so that [linalg.tags.order] can refer to rows and columns.
`layout_blas_packed::mapping::operator()`: Pass input parameters through _`index-cast`_ before using them in the formulas.
Remove spurious return value from `layout_blas_packed::mapping::stride` (the case where the Precondition would have been violated anyway).
22 tasks
mhoemmen
force-pushed
the
lwg-prep-kona
branch
from
bfe0a10 to
e44d2bf
Compare
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see list of changes here: #425 . Thanks!