OS-244 datafordeler address lookup#32
Open
stankut wants to merge 3 commits into
Open
Conversation
jekuaitk
requested changes
May 22, 2026
| namespace Drupal\os2web_datalookup\LookupResult; | ||
|
|
||
| /** | ||
| * Representation or value object for the result of a CPR lookup. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Representation or value object for the result of a CPR lookup. | |
| * Representation or value object for the result of an address lookup. |
| protected string $fullAddress; | ||
|
|
||
| /** | ||
| * Street of the person. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Street of the person. | |
| * Street. |
Or something similar
| protected $accessAddressId; | ||
|
|
||
| /** | ||
| * Name of the person. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Name of the person. | |
| * Full address. |
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function getSingleAddress(ParameterBag $params) : AddressLookupResult { |
Contributor
There was a problem hiding this comment.
This seems to be able to return NULL.
| use Drupal\Core\Form\FormStateInterface; | ||
| use Drupal\Core\Plugin\ContainerFactoryPluginInterface; | ||
| use Drupal\key\KeyRepositoryInterface; | ||
| use Drupal\os2forms_dawa\Entity\DatafordelerMatrikula; |
Contributor
There was a problem hiding this comment.
Do we need a os2forms_dawa dependency? Or should the entity perhaps be moved to this module? It seems strange for this in essence non-forms module to have a strict dependency on os2forms_dawa.
|
|
||
| $jsonDecoded = json_decode($json, TRUE); | ||
| if (is_array($jsonDecoded) && !empty($jsonDecoded)) { | ||
| if ($jsonDecoded['status'] == 'ok') { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ($jsonDecoded['status'] == 'ok') { | |
| if ($jsonDecoded['status'] === 'ok') { |
| $token = $this->getConfiguration()['token']; | ||
| $url = "https://adressevaelger.dk/adresser/soeg"; | ||
|
|
||
| $json = ''; |
Contributor
There was a problem hiding this comment.
I would suggest removing this and simply return the empty array in catch beneath if the request fails.
| $address = new AddressLookupResult(); | ||
| $address->setSuccessful(FALSE); | ||
|
|
||
| $json = ''; |
Contributor
There was a problem hiding this comment.
Remove and return $address in the catch
| public function getMatrikulaId(string $addressAccessId) : ?string { | ||
| $url = "https://services.datafordeler.dk/DAR/DAR/3.0.0/rest/husnummerTilJordstykke"; | ||
|
|
||
| $json = ''; |
Contributor
There was a problem hiding this comment.
Imo, remove and return early in catch
|
|
||
| $configuration = $this->getConfiguration(); | ||
|
|
||
| $json = ''; |
Contributor
There was a problem hiding this comment.
IMO, remove and return early in catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
OS2Forms/os2forms#246
Description
Introducing Datafordeler Address lookup.