Preproc main merge prep#158
Merged
Merged
Conversation
… bounds stored in the standardized OSIPI dictionary format. self.bounds will get manipulated by the individual algorithm subclasses
… not being found.
…ault b-value threshold
Wrapper dev testing
Update IAR_LU_modified_mix.py
Fixed typo in IAR_LU_modified_mix "fix"
Filter f extremes and deduplicate generic signals
Replace bare 'except:' with 'except Exception as e:' in OsipiBase.osipi_fit_full_volume() (line 377). Before: bare except caught KeyboardInterrupt/SystemExit (cannot Ctrl+C) and silently swallowed all errors with no diagnostic output. After: only catches Exception subclasses, adds diagnostic print() showing error type and message for debuggability. No regressions: 1127 passed, 167 skipped, 22 xfailed, 6 xpassed.
Implement Weighted Least Squares (WLS) segmented IVIM fitting following Veraart et al. (2013) NeuroImage 81:335-346. Algorithm: - Step 1: Fit D from high b-values via WLS on log-signal (w=S^2) - Step 2: Fit D* from residuals at low b-values via WLS New files: - src/original/DT_IIITN/wls_ivim_fitting.py (raw algorithm, numpy only) - src/standardized/DT_IIITN_WLS.py (OsipiBase standardized wrapper) Modified files: - tests/IVIMmodels/unit_tests/algorithms.json (register for automated tests) Follows repository contribution structure: - Fit code in src/original/Initials_Institution/ - Standardized wrapper in src/standardized/ - Registered in algorithms.json (no custom tests needed) Test results: 1184 passed, 167 skipped, 22 xfailed, 6 xpassed. 27 test_volume errors are pre-existing (FileNotFoundError on Windows).
fix: replace bare except with except Exception in osipi_fit_full_volume
Open PR for analysis
Added email addresses for authors and included optional dependencies for testing, documentation, and plotting.
feature: Add Weighted Least Squares (WLS) IVIM fitting algorithm — DT_IIITN (Feature #110)
…d the imports in /standardized
…ork with newer versions of python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Re-organized the /src/originals folder with adjustments to imports in other files
Checklist