Skip to content

chromium: build ChromeDriver#34

Merged
otavio merged 1 commit into
OSSystems:masterfrom
mrchapp:chromedriver-master
Apr 21, 2017
Merged

chromium: build ChromeDriver#34
otavio merged 1 commit into
OSSystems:masterfrom
mrchapp:chromedriver-master

Conversation

@mrchapp

@mrchapp mrchapp commented Apr 20, 2017

Copy link
Copy Markdown
Contributor

This patch enables the build of ChromeDriver. This comes
in very handy for test automation. More information can
be found here:
https://sites.google.com/a/chromium.org/chromedriver/

Signed-off-by: Daniel Díaz daniel.diaz@linaro.org

Comment thread recipes-browser/chromium/chromium.inc Outdated
FILES_${PN} += "${bindir}/${BPN}/*.pak"
FILES_${PN} += "${bindir}/${BPN}/locales/*.pak"

FILES_${PN}-chromedriver-dbg += "${bindir}/${BPN}/.debug/chromedriver"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep all debug together.

@twoerner

Copy link
Copy Markdown
Collaborator

By how much does this increase the build time of chromium? If it's a significant amount, it would be better if this were broken out so it is only built for those interested in it specifically.

@mrchapp mrchapp force-pushed the chromedriver-master branch from f49f75b to 0f1c827 Compare April 20, 2017 14:26
@twoerner

Copy link
Copy Markdown
Collaborator

Or maybe a default-off PACKAGECONFIG?

@fboudra

fboudra commented Apr 20, 2017

Copy link
Copy Markdown

@mrchapp I prefer if chromedriver is built by default unless the increased build time is significant. In that sense, I do agree with @twoerner . Please share the build time metrics so we can have the full picture.

@otavio

otavio commented Apr 20, 2017

Copy link
Copy Markdown
Member

Agreed and also a way to disable it might be on package config as well. Be it enabled or not by default.

mrchapp added a commit to mrchapp/meta-96boards that referenced this pull request Apr 20, 2017
This is a temporary bbappend so that ChromeDriver is
included in our builds while this pull request is merged
in upstream meta-browser:
  OSSystems/meta-browser#34

Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
@twoerner

twoerner commented Apr 20, 2017

Copy link
Copy Markdown
Collaborator

Everyone is welcome, of course, to do their own testing. In my testing I found no increase in overall build time. In fact the time to build with the patch went down by almost a minute. Of course I only did one build of each, but suffice to say it's not impacting build time in my one test at all :-)

current master:
real 47m52.100s
current master + merge request #34:
real 47m12.625s

Methodology:

  1. perform a full core-image-x11 build with chromium added to CORE_IMAGE_EXTRA_INSTALL
  2. $ bitbake -c cleansstate chromium
  3. $ time bitbake chromium (-> time chromium: adding updated version 24.0.1312.52 #1)
  4. $ bitbake -c cleansstate chromium
  5. apply patch
  6. $ time bitbake chromium (-> time Several updates #2)
  7. verify chromedriver was built and packaged

MACHINE = "dragonboard-410c"

@mrchapp

mrchapp commented Apr 20, 2017

Copy link
Copy Markdown
Contributor Author

@twoerner, fantastic! Lucky you -- my build only took 5 hours and 10 minutes. I added ninja chromedriver as an extra step in do_compile() and that part took 90 seconds. Definitely does not have any significant impact; if anything, it speeds up builds ;)

Would you guys still prefer to add another PACKAGECONFIG for this? Being a separate PACKAGE may suffice, but please advise.

By the way, the .debug part for chromedriver has been fixed, as requested by @otavio, in the original branch (force-pushed, probably messed that one up.)

@otavio

otavio commented Apr 21, 2017

Copy link
Copy Markdown
Member

Thanks for handling it. I think that adding a build option is worth the work, specially as it is straightforward.

This patch enables the build of ChromeDriver. This comes
in very handy for test automation. More information can
be found here:
  https://sites.google.com/a/chromium.org/chromedriver/

Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
@mrchapp mrchapp force-pushed the chromedriver-master branch from 0f1c827 to d8ca720 Compare April 21, 2017 04:05
@mrchapp

mrchapp commented Apr 21, 2017

Copy link
Copy Markdown
Contributor Author

Branch refreshed.

mrchapp added a commit to mrchapp/meta-96boards that referenced this pull request Apr 21, 2017
This is a temporary bbappend so that ChromeDriver is
included in our builds while this pull request is merged
in upstream meta-browser:
  OSSystems/meta-browser#34

Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
@otavio otavio merged commit cdb1b11 into OSSystems:master Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants