fix: patch ENABLE_MYOPENCRE in csv tests to bypass feature flag gate#884
Open
shiwani42 wants to merge 1 commit intoOWASP:mainfrom
Open
fix: patch ENABLE_MYOPENCRE in csv tests to bypass feature flag gate#884shiwani42 wants to merge 1 commit intoOWASP:mainfrom
shiwani42 wants to merge 1 commit intoOWASP:mainfrom
Conversation
ENABLE_MYOPENCRE is imported as a plain boolean at module load time in web_main.py, so setting os.environ after import has no effect. Patch application.web.web_main.ENABLE_MYOPENCRE directly so the routes are reachable in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #871
Summary
test_get_cre_csvandtest_import_from_cre_csvwere always returning 404 becauseENABLE_MYOPENCREis imported as a plain boolean at module load time inweb_main.py. Settingos.environafter import has no effect on the cached value. Patchingapplication.web.web_main.ENABLE_MYOPENCREdirectly ensures the routes are reachable during tests.Note: a related improvement around reading
ENABLE_MYOPENCREandGAP_ANALYSIS_OPTIMIZEDdynamically at request time rather than at import time was flagged in the issue thread. That is out of scope for this fix but worth a separate issue.Changes
application.web.web_main.ENABLE_MYOPENCREtoTruein bothtest_get_cre_csvandtest_import_from_cre_csvTest plan
test_get_cre_csvpassesweb_main_test.pypass with no regressions introducedtest_import_from_cre_csv) is a pre-existing bug onmaindue to an undefined function inspreadsheet_parsers.py(tracked in parse_export_format calls undefined function, crashes on any CSV import #860), unrelated to this changeblackformatting verified