Fix voting security: block voting before game starts and after game ends#2591
Closed
khushal-winner wants to merge 7 commits into
Closed
Fix voting security: block voting before game starts and after game ends#2591khushal-winner wants to merge 7 commits into
khushal-winner wants to merge 7 commits into
Conversation
khushal-winner
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
3 tasks
khushal-winner
force-pushed
the
voting-security-fix
branch
2 times, most recently
from
ba99bce to
0b19cd4
Compare
khushal-winner
force-pushed
the
voting-security-fix
branch
from
0b19cd4 to
8a13946
Compare
Collaborator
|
@khushal-winner your code has a build error. |
sydseter
requested changes
Mar 12, 2026
sydseter
left a comment
sydseter
left a comment
Collaborator
There was a problem hiding this comment.
You need to fix the build.
- Add missing end statement to close defmodule - Remove duplicate def topic/1 function - Add missing display_game_session/1 function - Resolve compilation errors for voting-security-fix branch
- Keep security validation from HEAD (voting-security-fix) - Preserve game_active? checks for voting lifecycle - Remove duplicate code blocks and merge markers - Maintain proper error handling and logging - Fix function structure and remove conflicts
Contributor
Author
|
@sydseter , is everything clear for merging? |
This was referenced Mar 23, 2026
Collaborator
|
@khushal-winner The test coverage has gone down. Please make sure it's higher then on master: https://github.com/OWASP/cornucopia/actions/runs/24130754439/job/70406497565 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes - #2568