Skip to content

[FEAT] interactive notebook, tests and function rename#241

Open
callumrollo wants to merge 1 commit intoOceanGlidersCommunity:mainfrom
callumrollo:interactive-nb
Open

[FEAT] interactive notebook, tests and function rename#241
callumrollo wants to merge 1 commit intoOceanGlidersCommunity:mainfrom
callumrollo:interactive-nb

Conversation

@callumrollo
Copy link
Member

This PR adds a notebook showcasing the interactive plots. It also adds tests to cover all the interactive functions as well as a small rename to remove the redundant interactive from glidertest.interactive.interactive_<function_name>

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@callumrollo
Copy link
Member Author

These segfaults are breaking my heart! Will troubleshoot tomorrow. Wonder why they're so fragile... I guess interactive plots are by definition difficult on a displayless test server

@callumrollo callumrollo changed the title interactive notebook, tests and function rename [FEAT] interactive notebook, tests and function rename Jun 12, 2025
@callumrollo
Copy link
Member Author

Now that I've actually read the log files from the failing tests after just making a bunch of dumb edits, it looks like it always fails during file handling

File "/home/runner/micromamba/envs/TEST/lib/python3.12/site-packages/xarray/backends/file_manager.py", line 217 in _acquire_with_cache_info

In another PR, the tests that failed are the ones that took a while to start. Maybe some kind of issue with multiple runners trying to download the demo dataset at the same time? callumrollo#7

Weird, but could be something. Wonder how to debug this

@callumrollo
Copy link
Member Author

I've made a PR where I set gh actions to set each runner (e..g ubuntu 3.10, windows 3.12) sequentially after the previous one finishes, rather than all at once. Looks like it works??

callumrollo#8

@MOchiara
Copy link
Member

Uhhh very interesting!

@callumrollo
Copy link
Member Author

maybe something going on with a xarray open of netCDF file not threadlocking? pydata/xarray#9779

idk man :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants