fix invites count calculation for admin dashboard#1806
Closed
Tirokk wants to merge 2 commits intopr1806basefrom
Closed
fix invites count calculation for admin dashboard#1806Tirokk wants to merge 2 commits intopr1806basefrom
Tirokk wants to merge 2 commits intopr1806basefrom
Conversation
Tirokk
commented
Oct 6, 2020
| }) | ||
|
|
||
| /* | ||
| * Note: invites count is calculated this way because invitation codes are not in use yet |
Member
Author
There was a problem hiding this comment.
Authored by roschaefer
Oct 3, 2019
Outdated (history rewrite) - original diff
@@ -28,6 +28,11 @@ export default {
const stat = statistics[mapping[key]]
response[key] = stat ? stat.toNumber() : 0
})
+
+ /*
+ * Note: invites count is calculated this way because invitation codes are not in use yetWe learned the day before yesterday that we open registration for non-donators in two weeks from now. So, Invitation codes will not be necessary anymore. (Just as a side note)
Member
Author
There was a problem hiding this comment.
Mogge
approved these changes
Oct 8, 2020
Contributor
Mogge
left a comment
There was a problem hiding this comment.
@vbelolapotkov this is great! I also love your simple solution to subtract the registered users from emails. I would have solved it with counting email addresses like this:
MATCH e:EmailAddress WHERE NOT (e)-[:BELONGS_TO]->()
but I think as long as we have at most one email address per user, your calculation is correct!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🍰 Pullrequest
This is a workaround solution for counting invites for admin dashboard suggested by @roschaefer in #1633
Issues
Todo