Skip to content

fix invites count calculation for admin dashboard#1806

Closed
Tirokk wants to merge 2 commits intopr1806basefrom
pr1806head
Closed

fix invites count calculation for admin dashboard#1806
Tirokk wants to merge 2 commits intopr1806basefrom
pr1806head

Conversation

@Tirokk
Copy link
Member

@Tirokk Tirokk commented Oct 5, 2020

vbelolapotkov Authored by vbelolapotkov
Oct 3, 2019
Merged Oct 3, 2019


🍰 Pullrequest

This is a workaround solution for counting invites for admin dashboard suggested by @roschaefer in #1633

Issues

Todo

  • None

})

/*
* Note: invites count is calculated this way because invitation codes are not in use yet
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roschaefer Authored by roschaefer
Oct 3, 2019


Outdated (history rewrite) - original diff


@@ -28,6 +28,11 @@ export default {
           const stat = statistics[mapping[key]]
           response[key] = stat ? stat.toNumber() : 0
         })
+
+        /*
+         * Note: invites count is calculated this way because invitation codes are not in use yet

We learned the day before yesterday that we open registration for non-donators in two weeks from now. So, Invitation codes will not be necessary anymore. (Just as a side note)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vbelolapotkov Authored by vbelolapotkov
Oct 4, 2019


Thanks, good to know about invitation codes.

@Tirokk Tirokk mentioned this pull request Oct 6, 2020
1 task
Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbelolapotkov this is great! I also love your simple solution to subtract the registered users from emails. I would have solved it with counting email addresses like this:

MATCH e:EmailAddress WHERE NOT (e)-[:BELONGS_TO]->()

but I think as long as we have at most one email address per user, your calculation is correct!

Great

@Mogge Mogge closed this Oct 8, 2020
@ulfgebhardt ulfgebhardt deleted the pr1806head branch January 7, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants