Support username/password again - #113
Merged
Merged
Conversation
michaelnoonan
approved these changes
Feb 28, 2019
michaelnoonan
left a comment
michaelnoonan
left a comment
Contributor
There was a problem hiding this comment.
It will do what it says on the tin. One comment on simplifying.
| { | ||
| using (var client = await CreateClient()) | ||
| { | ||
| var repository = new OctopusAsyncRepository(client); |
Contributor
There was a problem hiding this comment.
It looks like client.SignIn(...) should also do this with less confusing code. https://github.com/OctopusDeploy/OctopusClients/blob/04dc7dea34fe6569c453268f1bc5f54c174b75a3/source/Octopus.Client/OctopusAsyncClient.cs#L171
Contributor
There was a problem hiding this comment.
If you decide to stick with UserRepository.SignIn() the var repository is only used inside the if.
Contributor
Author
|
Fixed in cf114f4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/OctopusDeploy/Issues/issues/5347