Correctly look for known tag when matching versions.json tag not found - #1274
Merged
Conversation
APErebus
changed the title
LukeButters
approved these changes
Jul 23, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I noticed in my k3s cluster, which is running
1.36.xof K8s, that the agent was using thelatesttag of the agent tools. We are publishing a1.36of the agent tools image, so what's going on?Results
There was a bug/issue where if the cluster version was newer than the
latestvalue in the versions metadata, it would just fallback to thelatesttag.Now if we can't get the version metadata or specifically use a deprecated image tag or a known tag matching the cluster version, we just fallback to the list of known tags or
latestif nothing matchesHow to review this PR
Quality ✔️
Pre-requisites