This repository was archived by the owner on Sep 26, 2024. It is now read-only.
Check for open redirection attacks - #2
Merged
Merged
Conversation
…hind a reverse proxy, and provide error messages if the heades aren't being passed through correctly
…so added checks for open redirection attacks
michaelnoonan
suggested changes
Nov 14, 2016
| state = postLoginRedirectTo; | ||
|
|
||
| string[] whitelist = null; | ||
| if (Debugger.IsAttached) |
Contributor
There was a problem hiding this comment.
I feel like this whitelist should be provided by the Octopus Server somehow - it knows which mode it's running in. Here we're kind of doing it "ambiently" by picking up if a Debugger is attached.
Can the Octopus Server provide a "service" which the extensions can query for a whitelist? I feel like this would be less brittle. Especially if we need to allow people to specify their own whitelist as a configuration option.
Actually, that might not be a bad idea either, make it a configuration option which our scripts fill in with localhost
tothegills
pushed a commit
that referenced
this pull request
Mar 31, 2023
Updating Repo from upstream changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added checks for open redirection attacks and updated packages to get latest virtual directory path handling implementation.