Skip to content

Adds workflow to approve renovate PRs - #57

Merged
geofflamrock merged 2 commits into
mainfrom
geoffl/approve-renovate-prs
Sep 13, 2022
Merged

Adds workflow to approve renovate PRs#57
geofflamrock merged 2 commits into
mainfrom
geoffl/approve-renovate-prs

Conversation

@geofflamrock

@geofflamrock geofflamrock commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

Dependencies within the util-actions repo are automatically updated using renovate. This involves creating a PR with a dependency update which can then be auto-merged by renovate if all it's checks pass and it is performing a patch or digest level change.

#project-miso-change-control has introduced a PRGB requirement for all changes to our software. In the context of renovate we already have a PR with builds but renovate can no longer auto-merge without an approval on the PR.

This PR introduces a workflow that will auto-approve any PR that is opened by renovate. PRs that are not patch/digest changes should still not be auto-merged by renovate and will need manual review/merging.

Shortcut (internal): util-actions Add workflow to approve renovate [sc-9309]

@shortcut-integration

Copy link
Copy Markdown

This pull request has been linked to Shortcut Story #9309: util-actions: Add workflow to approve renovate PRs.

@scme0

scme0 commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

How does it check if it's just a patch of digest level change?

@geofflamrock

Copy link
Copy Markdown
Contributor Author

How does it check if it's just a patch of digest level change?

Renovate knows how to check based on the current dependency version and the one it is updating to e.g. if we have a dependency on a package with version 1.2.0 and renovate finds a new version 1.2.1 it knows it's a patch update. There is configuration within the repo which defines what renovate will do with these types of changes, in our case it will auto-merge the PRs for patch/digest once they have been approved.

@scme0 scme0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geofflamrock
geofflamrock merged commit fbdcb9e into main Sep 13, 2022
@geofflamrock
geofflamrock deleted the geoffl/approve-renovate-prs branch September 13, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants