fix(deps): bump react-router to 7.18.1 (clears 4 of 6 alerts) - #48
Open
Trifunovich wants to merge 1 commit into
Open
fix(deps): bump react-router to 7.18.1 (clears 4 of 6 alerts)#48Trifunovich wants to merge 1 commit into
Trifunovich wants to merge 1 commit into
Conversation
- lockfile-only: package.json ^7.17.0 already permits 7.18.1 - dependabot could not do this: react-router is transitive and pinned exactly by react-router-dom, so its security job errored - verified npm ci + tests on node:24 glibc, npm ci + build on node:20-alpine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
Bumps
react-router/react-router-dom7.17.0 -> 7.18.1. Lockfile only —package.jsonalready declares^7.17.0, which permits 7.18.1.Clears 4 of the 6 open alerts
deserializeErrors()<Link>/useNavigateThe remaining react-router high needs 8.3.0. That is not a version bump:
react-router-domhas no 8.x (latest is 7.18.1), so v8 means rewriting everyreact-router-domimport toreact-router. Tracked separately.Both unfixed-here advisories are RSC-mode issues. This app is a client-side SPA (
BrowserRouter,vite build, no SSR/RSC entry point), so neither is reachable in the current configuration.Why Dependabot could not do this
Its security job targeted
react-router, which is transitive here and pinned exactly byreact-router-dom@7.17.0:It runs with
allowed-updates: directandupdate-subdependencies: false, so it cannot lift a transitive package, and it will not re-propose the direct bump because PR #7 for exactly 7.18.1 was closed on 2026-07-03 (collateral of amainhistory rewrite, not a rejection).Validation
Lockfile regenerated with a full install (not
--package-lock-only) onnode:24, preserving thelibcmetadata. Both CI consumers exercised in matching containers:node:24(glibc, npm 11.16.0) —npm ci+npm test: 15 files, 101 tests passnode:20-alpine(musl, npm 10.8.2) —npm ci+npm run build: builds cleanDiff is 7 insertions / 7 deletions: version, resolved, integrity for both packages plus the internal pin.