Skip to content

Make Dockerfile and docker-compose.yml work with 2.0.1-SNAPSHOT - #18

Merged
barbeau merged 3 commits into
OneBusAway:masterfrom
brodyFlannigan:master
Apr 28, 2020
Merged

Make Dockerfile and docker-compose.yml work with 2.0.1-SNAPSHOT#18
barbeau merged 3 commits into
OneBusAway:masterfrom
brodyFlannigan:master

Conversation

@brodyFlannigan

@brodyFlannigan brodyFlannigan commented Apr 28, 2020

Copy link
Copy Markdown
Contributor

This fixes the issue raised in #15.

Fixes #15.

@CLAassistant

CLAassistant commented Apr 28, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@brodyFlannigan

Copy link
Copy Markdown
Contributor Author

Closing and re-opening to restart Travis.
I had forgotten to edit the bin/ci script

@barbeau

barbeau commented Apr 28, 2020

Copy link
Copy Markdown
Member

Hmmm...Travis failed with this:

Successfully tagged oba-ci:latest
=== building bundle
=== running postgres
Unable to find image 'postgres:10' locally
10: Pulling from library/postgres
Status: Downloaded newer image for postgres:10
745c03a797d5a74ff9b2801d4d92be6a8e97b84b8e3aaefa7458cd573739e751
=== creating postgres database
Error response from daemon: No such container: oba-postgres
Error: No such container: oba-postgres
Error: No such container: oba-postgres
Error: No such container: oba-postgres
Error: No such container: oba-postgres
Error: No such container: oba-postgres
Error: No such container: oba-postgres
Error: No such container: oba-postgres
Error: No such container: oba-postgres
Error: No such container: oba-postgres
postgres didn't work
The command "bin/ci" exited with 1.

@brodyFlannigan

Copy link
Copy Markdown
Contributor Author

I find that quite odd.
I only changed 2.0.0-SNAPSHOT to 2.0.1-SNAPSHOT.

I can't see why it would fail...

@barbeau

barbeau commented Apr 28, 2020

Copy link
Copy Markdown
Member

For some reason I can't restart the Travis build directly on Travis, so I'm closing and re-opening to restart the build to see if it was an intermittent issue.

@barbeau barbeau closed this Apr 28, 2020
@barbeau barbeau reopened this Apr 28, 2020
@barbeau

barbeau commented Apr 28, 2020

Copy link
Copy Markdown
Member

Nope, same failure again in https://travis-ci.org/github/OneBusAway/onebusaway-docker/builds/680634315. 🤔

@barbeau

barbeau commented Apr 28, 2020

Copy link
Copy Markdown
Member

To see if this is something external, I'm going to restart this build, which previously passed prior to merge into the master branch:
https://travis-ci.org/github/OneBusAway/onebusaway-docker/builds/559059670

@barbeau

barbeau commented Apr 28, 2020

Copy link
Copy Markdown
Member

Well, that didn't work because we're checking out the master branch and the whole 2.0.1 issue...

@brodyFlannigan

Copy link
Copy Markdown
Contributor Author

It could very well be my fault as I am new to this "pull request" business...

All I know is that once I made the changes to my files docker composed flawlessly when I told it docker compose up build-bundle...

@barbeau

barbeau commented Apr 28, 2020

Copy link
Copy Markdown
Member

@dudebrains01 I think your PR is fine, there seems to be something else going on preventing CI from working with postgres.

If this works for you locally, I'm inclined to merge and figure out what's going on with CI separately. Master branch of this project is definitely broken due to the version changes in oba-app-modules and that needs to be fixed.

@barbeau
barbeau merged commit bc414ae into OneBusAway:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build issues

3 participants