Prompt for "Are you sure you want to cancel the request process and not add the products to your shopping cart?" is always closing sidesheet#65
Closed
asattler wants to merge 1 commit into
Closed
Conversation
Without the added "else if", the sideSheet will always get closed even though the User declined the "Heading Cancel Request Process" prompt in line 53
Contributor
|
@asattler this is a valid PR but this function needs to be refactored overall - it is unnecessarily complex and that is what promoted this bug in the first place. We have changed this to an internal item to refactor for v91 & v92. As such I will reject this PR but this will be fixed internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the added "else if", the sideSheet will always get closed even though the User declined the "Heading Cancel Request Process" prompt in line 53