OneIdentity · hannobunjes · Sep 1, 2023 · Sep 1, 2023 · Sep 1, 2023
diff --git a/.commit b/.commit
@@ -1 +1 @@
-e7d60a81cd6c956aa923db9d327aff35a7086cf9
+ff4ac3907cfcb600aa23b23e1aeb401dcf3d68cd
diff --git a/README.md b/README.md
@@ -4,6 +4,20 @@
 
 ## Change log
 
+### September 1, 2023
+
+The `v91` branch has been updated with fixes for the following issues.
+
+- 426598 The counter of selected optional products was sometimes showing an incorrect value
+- 427961/37144 Adding items to the shopping cart did not work
+- 426872 Policy violation was not using the correct set of standard justifications
+- 426767 Fixed UI layout in request approval sidesheet
+- 415340 Password Reset Portal was sometimes hanging at the loading screen
+- 424223 Refactoring of sidesheet closing (https://github.com/OneIdentity/IdentityManager.Imx/pull/65)
+- 419508 Application Governance KPIs were not correctly adapting to the screens ize
+- 423861/36856/423948 Fix UI when a manager has only indirect, but no direct reports
+- 421566 Fix LDS keys for product names
+
 ### June 23, 2023
 
 This update addresses the following security issues.

diff --git a/imxweb/projects/aob/src/lib/kpi/kpi-overview/kpi-overview.component.html b/imxweb/projects/aob/src/lib/kpi/kpi-overview/kpi-overview.component.html
@@ -15,7 +15,7 @@ <h4 *ngIf="chartDataFail.length > 0">{{ '#LDS#Failed' | translate }}</h4>
               <div class="imx-kpi-text" [matTooltip]="chart.Display">{{ chart.Display }}</div>
             </mat-card-content>
             <mat-card-actions class ="imx-kpi-tile-actions">
-              <button *ngIf="hasDetails(chart)" mat-button data-imx-identifier="KPI_overview_showFailedShowDetails"
+              <button *ngIf="hasDetails(chart)" mat-stroked-button data-imx-identifier="KPI_overview_showFailedShowDetails"
               (click)="showDetails(chart, true)">{{ '#LDS#Details' | translate }}</button>
             </mat-card-actions>
         </mat-card>
@@ -32,7 +32,7 @@ <h4 *ngIf="chartDataPass.length > 0">{{ '#LDS#Passed' | translate }}</h4>
             <div class="imx-kpi-text" [matTooltip]="chart.Display">{{ chart.Display }}</div>
           </mat-card-content>
           <mat-card-actions class ="imx-kpi-tile-actions">
-            <button *ngIf="hasDetails(chart)" mat-button data-imx-identifier="KPI_overview_showPassedShowDetails"
+            <button *ngIf="hasDetails(chart)" mat-stroked-button data-imx-identifier="KPI_overview_showPassedShowDetails"
             (click)="showDetails(chart, false)">{{ '#LDS#Details' | translate }}</button>
           </mat-card-actions>
         </mat-card>
@@ -46,7 +46,7 @@ <h4 *ngIf="chartDataPass.length > 0">{{ '#LDS#Passed' | translate }}</h4>
 <ng-template #chartdialog let-data>
   <div mat-dialog-title>
     <div [ngClass]="data.failed? 'imx-fail imx-title-text':'imx-pass imx-title-text'">{{ (data.failed ? '#LDS#Failed': '#LDS#Passed') | translate }}</div>
-    <button mat-icon-button color="basic" class="imx-close-dialog-button" data-imx-identifier="KPI_overview_closeChartDialog" mat-dialog-close>
+    <button mat-icon-button  class="mat-button imx-close-dialog-button" data-imx-identifier="KPI_overview_closeChartDialog" mat-dialog-close>
       <eui-icon icon="close" size="large"></eui-icon>
     </button>
   </div>

diff --git a/imxweb/projects/aob/src/lib/kpi/kpi-overview/kpi-overview.component.scss b/imxweb/projects/aob/src/lib/kpi/kpi-overview/kpi-overview.component.scss
@@ -1,5 +1,4 @@
-@use '@angular/material' as mat;
-@import '@elemental-ui/core/src/styles/_palette.scss';
+@import '@elemental-ui/core/src/styles/_eui_palette.scss';
 
 :host{
   flex: 1 1 auto;
@@ -9,20 +8,19 @@
 
 .imx-kpi-site {
   padding: 16px 40px;
-  background-color: mat.get-color-from-palette($asher-gray-palette, 100);
   height: auto;
   min-height: 100%;
   display: flex;
   flex-direction: column;
   flex: 1 1 auto;
+  overflow: auto;
 }
 
 li {
   list-style-type: none;
   margin: 0 10px 10px 0;
 
   .mat-card {
-    background-color: $white;
     width: 340px;
     height: 68px;
     display: grid;
@@ -40,13 +38,13 @@ li {
 
 h2 {
   font-size: 20px;
-  color: $black-3;
+  color: $color-gray-30;
   margin-bottom: 8px;
 }
 
 p {
   font-size: 14px;
-  color: $black-9;
+  color: $color-gray-80;
   margin-top: 0;
 }
 
@@ -94,8 +92,6 @@ h4 {
   font-size: 24px;
   line-height: 38px;
   font-weight: 900;
-  margin: 0 20px 0 0px;
-  color: $aspen-green;
   grid-column: 1;
 }
 
@@ -106,6 +102,7 @@ h4 {
   > li > .mat-card {
     display: flex;
     height: 100%;
+    justify-content: space-between;
   }
 }
 
@@ -124,9 +121,6 @@ h4 {
   margin: 0px 0 10px;
 }
 
-.imx-fail {
-  color: $phoenix-red;
-}
 
 .imx-title-text {
   text-align: center;
@@ -143,18 +137,44 @@ h4 {
   display: flex;
   flex-direction: column;
   align-items: center;
-  margin-bottom: 10px;
-  margin-top: 10px;
-  background-color: mat.get-color-from-palette($asher-gray-palette, 100);
-  height: auto;
-  min-height: calc(100% - 20px);
+  justify-content: center;
+  height: 100%;
 
   h2 {
     font-weight: 600;
-    margin-top: 30px;
+  }
+}
+
+:host {
+  .imx-kpi-site {
+    background-color: $color-gray-2;
+    }
+
+  .imx-aob-kpi-empty {
+    background-color: $color-gray-2;
+    color: $color-gray-50;
+  }
+
+  .imx-pass {
+    color: $color-green-60;
+  }
+
+  .imx-fail {
+    color: $color-red-60;
+  }
+}
+
+
+::ng-deep .kpi-overview-modal {
+  .imx-title-text {
+    color: $color-gray-80;
+  }
+
+  .imx-pass {
+    color: $color-green-60;
   }
 
-  >.eui-icon {
-    color: $black-b;
+  .imx-fail {
+    color: $color-red-60;
   }
 }
diff --git a/imxweb/projects/aob/src/lib/kpi/kpi-overview/kpi-overview.component.ts b/imxweb/projects/aob/src/lib/kpi/kpi-overview/kpi-overview.component.ts
@@ -110,7 +110,7 @@ export class KpiOverviewComponent implements OnChanges {
    */
   public showDetails(chart: ChartDto, isFail: boolean): void {
     if (!this.hasDetails(chart)) { return; }
-    this.matDialog.open(this.chartDialog, { data: { chart: this.getChartData(chart), failed: isFail }, width: '600px', autoFocus: false });
+    this.matDialog.open(this.chartDialog, { data: { chart: this.getChartData(chart), failed: isFail }, width: '600px', autoFocus: false, panelClass: 'kpi-overview-modal' });
   }
 
   /**
@@ -189,6 +189,10 @@ export class KpiOverviewComponent implements OnChanges {
         text: this.errorThreshhold
       }
     ];
+    lineChartOptions.size = {
+      height: 400,
+      width: 500
+    }
     this.logger.debug(this, 'Options', lineChartOptions.options);
     return lineChartOptions.options;
   }

diff --git a/imxweb/projects/att/src/lib/new-user/new-user.module.ts b/imxweb/projects/att/src/lib/new-user/new-user.module.ts
@@ -34,7 +34,17 @@ import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
 import { Router, Routes } from '@angular/router';
 import { EuiCoreModule } from '@elemental-ui/core';
 import { TranslateModule } from '@ngx-translate/core';
-import { AuthConfigProvider, AuthenticationService, CaptchaModule, CdrModule, CustomAuthFlow, MastHeadModule, ParameterizedTextModule, UserMessageModule } from 'qbm';
+import {
+  AuthConfigProvider,
+  AuthenticationService,
+  CaptchaModule,
+  CdrModule,
+  CustomAuthFlow,
+  MastHeadModule,
+  ParameterizedTextModule,
+  UserMessageModule,
+  ClassloggerService,
+} from 'qbm';
 import { ApiService } from '../api.service';
 import { ConfirmDialogComponent } from './confirm-dialog.component';
 import { NewUserComponent } from './new-user.component';
@@ -44,8 +54,8 @@ import { UserActivationComponent } from './user-activation.component';
 const routes: Routes = [
   {
     path: 'useractivation',
-    component: UserActivationComponent
-  }
+    component: UserActivationComponent,
+  },
 ];
 
 @NgModule({
@@ -63,49 +73,40 @@ const routes: Routes = [
     ParameterizedTextModule,
     UserMessageModule,
     TranslateModule,
-    EuiCoreModule
-  ],
-  declarations: [
-    OpenSidesheetComponent,
-    NewUserComponent,
-    UserActivationComponent,
-    ConfirmDialogComponent
+    EuiCoreModule,
   ],
+  declarations: [OpenSidesheetComponent, NewUserComponent, UserActivationComponent, ConfirmDialogComponent],
 })
 export class NewUserModule {
-  constructor(authService: AuthenticationService, router: Router, apiService: ApiService) {
-
+  constructor(authService: AuthenticationService, router: Router, apiService: ApiService, private readonly logger: ClassloggerService) {
     const newUserAuthProvider: AuthConfigProvider = {
       display: '#LDS#Create new account',
       name: 'NewUser',
       authProps: [],
-      customAuthFlow: new NewUserFlow()
+      customAuthFlow: new NewUserFlow(),
     };
 
-    apiService.client.register_featureconfig_get().then(c => {
+    apiService.client.register_featureconfig_get().then((c) => {
       if (c.SelfRegistrationEnabled) {
         authService.registerAuthConfigProvider(newUserAuthProvider);
       }
     });
 
-
+    this.logger.info(this, '▶️ NewUser initialized');
     this.addRoutes(router);
   }
 
   private addRoutes(router: Router): void {
     const config = router.config;
-    routes.forEach(route => {
+    routes.forEach((route) => {
       config.unshift(route);
     });
     router.resetConfig(config);
   }
-
 }
 
 class NewUserFlow implements CustomAuthFlow {
-
   public getEntryComponent() {
     return OpenSidesheetComponent;
   }
 }
-
diff --git a/imxweb/projects/att/src/lib/new-user/user-activation.component.html b/imxweb/projects/att/src/lib/new-user/user-activation.component.html
@@ -9,21 +9,9 @@ <h1 class="mat-headline">{{ '#LDS#Heading Confirm Email Address' | translate }}<
 	<mat-spinner *ngIf="busy"></mat-spinner>
 
 	<ng-container *ngIf="!busy">
-		<ng-container *ngIf="data">
-
-			<!-- ApprovalState meanings: 0=Certified, 1=New, 3=Denied-->
-			<eui-alert *ngIf="data.ApprovalState == 0">{{ldsAlreadyCompleted| translate}}</eui-alert>
-			<eui-alert *ngIf="data.ApprovalState == 1">{{ldsConfirmationText| translate}}</eui-alert>
-			<eui-alert *ngIf="data.ApprovalState == 3">{{ldsRegistrationDenied| translate}}</eui-alert>
-		</ng-container>
-
-		<eui-alert *ngIf="!data && missingCase && !hasProblems">{{ldsCompletionFailed| translate}}</eui-alert>
-		<eui-alert *ngIf="!data && !missingCase && !hasProblems">{{ldsResendEmail| translate}}</eui-alert>
-		<eui-alert *ngIf="!missingCase && hasProblems">{{ldsLoadingProblems| translate}}</eui-alert>
-
-
+    <eui-alert>{{ldsText| translate}}</eui-alert>
 		<div class="button-bar">
-			<button mat-raised-button *ngIf="!missingCase && !hasProblems" (click)="ReSendMail()">{{ldsSendAgain |
+			<button mat-raised-button *ngIf="hasFormat && !hasProblems" (click)="ReSendMail()">{{'#LDS#Send confirmation email again' |
 				translate}}
 			</button>
 
@@ -32,4 +20,4 @@ <h1 class="mat-headline">{{ '#LDS#Heading Confirm Email Address' | translate }}<
 			</button>
 		</div>
 	</ng-container>
-</div>
+</div>
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		e7d60a81cd6c956aa923db9d327aff35a7086cf9
		ff4ac3907cfcb600aa23b23e1aeb401dcf3d68cd