Remove leading slash from smwQueryUrl#30
Closed
Bovine-collab wants to merge 1 commit into
Closed
Conversation
When wgScriptPath is set, this already includes a leading slash. For instance, the default value is '/wiki'. With the old logic in place, this would result in calling '//index.php/Special:FlexForm'
Collaborator
|
Hi! Thanks for this, however for us that is not the case ( we do not have a leading trailing slash). I'd rather have a ltrim for the "/". Something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When 'wgScriptPath' is set, this already includes a leading slash. For instance, the default value is '/wiki'. With the old logic in place, this would result in calling '//index.php/Special:FlexForm' - which fails to load any result. Removing the leading slash fixes it.