Skip to content

Convert setup.py to pyproject.toml#908

Open
pjonsson wants to merge 1 commit into
Open-EO:masterfrom
pjonsson:migrate-to-pyproject
Open

Convert setup.py to pyproject.toml#908
pjonsson wants to merge 1 commit into
Open-EO:masterfrom
pjonsson:migrate-to-pyproject

Conversation

@pjonsson

@pjonsson pjonsson commented Jul 6, 2026

Copy link
Copy Markdown

The same files are included before/after
when doing "python3 -m build" on
my machine.

@pjonsson pjonsson force-pushed the migrate-to-pyproject branch 2 times, most recently from 8cd76e4 to f40b6c2 Compare July 6, 2026 09:00
@pjonsson

pjonsson commented Jul 6, 2026

Copy link
Copy Markdown
Author

I can't see the log from continuous-integration/jenkins/pr-head, so not sure why that is red.

@soxofaan

Copy link
Copy Markdown
Member

from the error logs:

+ setuptools==75.3.4
 + setuptools-lint==0.6.0
 + toml==0.10.2
 + typing-extensions==4.13.2
 + wrapt==1.13.3
+ '[' -f requirements.txt ']'
+ '[' -f setup.py ']'
+ '[' -f setup.cfg ']'
+ uv pip install '.[tests]'
Using Python 3.8.8 environment at: venv38
  × Failed to build `openeo @
  │ [file:///var/lib/jenkins/workspace/enEO_openeo-python-client_PR-908`](file:///var/lib/jenkins/workspace/enEO_openeo-python-client_PR-908%60)
  ├─▶ The build backend returned an error
  ╰─▶ Call to `setuptools.build_meta.build_wheel` failed (exit status: 1)

      [stdout]
      configuration error: `project.license` must be valid exactly by one
      definition (2 matches found):

          - keys:
              'file': {type: string}
            required: ['file']
          - keys:
              'text': {type: string}
            required: ['text']

      DESCRIPTION:
          `Project license <https://peps.python.org/pep-0621/#license>`_.

      GIVEN VALUE:
          "Apache-2.0"

as far as I understand the license field should not be a string but a mapping with field "text" containing that string.
This is probably because the build chain used here is stuck at outdated conventions

@soxofaan

Copy link
Copy Markdown
Member

probably related to

@pjonsson pjonsson force-pushed the migrate-to-pyproject branch 2 times, most recently from 9c86048 to 15d8ce8 Compare July 13, 2026 10:27
@pjonsson

Copy link
Copy Markdown
Author

@soxofaan ok, this revision of the PR works in a Python 3.8 container for me, and I've rebased to latest master.

@pjonsson pjonsson force-pushed the migrate-to-pyproject branch from 15d8ce8 to c18db73 Compare July 13, 2026 11:09
@pjonsson

Copy link
Copy Markdown
Author

Still red in the CI despite building locally, so I'm guessing the CI logs that I can't see are trying to run uv run pytest after installing the tests dependencies.

Accepted any version of sphinx-autodoc-typehints for Python versions that have reached end of life, and skipped openeo_pg_parser_networkx/openeo_processes_dask[implementations] on Python 3.8: https://github.com/Open-EO/openeo-python-client/compare/15d8ce848ba2ec05ead03de7db0a5398b6d0ce4f..c18db737723efc375efd4d75916f1ec87a470eff and after that I can run the tests in the Python 3.8 container locally as well (and they pass).

The same files are included before/after
when doing "python3 -m build" on
my machine.
@pjonsson pjonsson force-pushed the migrate-to-pyproject branch from c18db73 to 8900d43 Compare July 13, 2026 11:26
@pjonsson

Copy link
Copy Markdown
Author

Apparently still red, but I can't guess what the CI does next, so I need to see some more logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants