Skip to content

Compare GeoJSON assets in job result tests#913

Open
Silvren wants to merge 1 commit into
Open-EO:masterfrom
Silvren:agent/compare-vector-job-results
Open

Compare GeoJSON assets in job result tests#913
Silvren wants to merge 1 commit into
Open-EO:masterfrom
Silvren:agent/compare-vector-job-results

Conversation

@Silvren

@Silvren Silvren commented Jul 13, 2026

Copy link
Copy Markdown

Summary

  • recognize .geojson assets in assert_job_results_allclose instead of treating them as unhandled files
  • compare feature attributes with the existing relative and absolute tolerances
  • compare geometry types, geometry values, feature order, and coordinate reference systems through GeoPandas
  • report attribute and geometry mismatches separately for actionable failures

Testing

  • python -m pytest tests/testing -q (84 passed)
  • pre-commit run --files CHANGELOG.md openeo/testing/results.py tests/testing/test_results.py

Fixes #862

@Silvren

Silvren commented Jul 13, 2026

Copy link
Copy Markdown
Author

Thanks for the notification. I tried to inspect the Jenkins console, but jenkins.vgt.vito.be currently returns NXDOMAIN through both my system DNS and public DNS, so the console is not reachable from my network.

I reproduced the PR branch locally:

  • python -m pytest tests/testing/test_results.py -q: 56 passed
  • python -m pytest tests/testing -q: 84 passed
  • git diff --check: passed

GitHub also shows two workflows awaiting maintainer approval. Could you please approve/re-run the workflows and retry the Jenkins build? If Jenkins still fails, sharing the first relevant traceback from the console would help me address it. Thanks!

@Silvren Silvren force-pushed the agent/compare-vector-job-results branch from 569a926 to e11ee92 Compare July 13, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support vector cube comparison in openeo.testing.results

1 participant