修复翻译页保存失败无提示#328
Merged
H-Chris233 merged 1 commit intoMay 7, 2026
Merged
Conversation
Translation settings were optimistically updated without awaiting or surfacing write failures, so users could see enabled language and shortcut states that were never persisted. This keeps the fix inside the Translation page: all three save paths now show saving/saved/failed feedback, catch failed writes, and refresh preferences after failed preference persistence to roll back local state. Constraint: Follow the new beta-first PR workflow from Open-Less#327. Rejected: Refactor HotkeySettingsContext queue behavior | issue explicitly excludes queue redesign. Confidence: high Scope-risk: narrow Directive: Keep Translation page save feedback local unless SelectionAsk receives the same treatment in its own issue. Tested: npm run build Tested: git diff --check Related: Open-Less#314
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
摘要
验证
npm run buildgit diff --checkCloses #314
PR Type
Bug fix, Enhancement
Description
Add save feedback banner
Catch translation save failures
Separate hotkey register errors
Localize new failure messages
Diagram Walkthrough
File Walkthrough
Translation.tsx
Add save-state feedback to translation pageopenless-all/app/src/pages/Translation.tsx
saving,saved, andfailedUI states with a dismissingstatus banner.
async helper with error handling.
steps, stopping on registration failure.
UI state.
en.ts
Add English translation save errorsopenless-all/app/src/i18n/en.ts
failures.
ja.ts
Add Japanese translation save errorsopenless-all/app/src/i18n/ja.ts
failures.
ko.ts
Add Korean translation save errorsopenless-all/app/src/i18n/ko.ts
failures.
zh-CN.ts
Add Simplified Chinese save failuresopenless-all/app/src/i18n/zh-CN.ts
failures.
zh-TW.ts
Add Traditional Chinese save failuresopenless-all/app/src/i18n/zh-TW.ts
failures.