修复 Style 总开关关闭后的兜底风格

[H-Chris233]

User description

摘要

• 选择 [ui][bug] Style 页"总开关"注释与实现不一致 — 注释说留 raw/default 兜底，实际全清空 #312 中的方案 A：Style 页总开关关闭时保留 raw 和当前 defaultMode，不再持久化空的 enabledModes。
• 将 master toggle 的兜底风格与开关显示判定集中到 stylePrefs，避免 UI 状态和保存值再次分叉。
• 补充手写回归测试，覆盖 master toggle off 后的最终 enabledModes。

Closes #312

验证

• cd openless-all/app && npx tsx src/lib/stylePrefs.test.ts
• cd openless-all/app && npm run build

备注

coordinator.rs 中 enabled_modes 目前用于切换风格热键过滤；听写主流程仍读取 default_mode。因此本修复避免空集合让风格热键无可选项，同时保持主听写路径行为稳定。

---

PR Type

Bug fix, Tests

---

Description

• Preserve raw/default fallback modes

• Keep master-off state stable

• Recompute saved modes after default changes

• Add regression coverage for toggle and rollback

---

Diagram Walkthrough

flowchart LR
  StylePage["Style page"]
  StylePrefs["stylePrefs helpers"]
  IPC["Settings IPC"]
  Tests["Regression tests"]

  StylePage -- "toggle default / master" --> StylePrefs
  StylePrefs -- "persist fallback modes" --> IPC
  Tests -- "verify master-off semantics" --> StylePrefs

Loading

File Walkthrough

	Relevant files
Bug fix	stylePrefs.ts Centralize style master fallback and rollback logic            openless-all/app/src/lib/stylePrefs.ts Adds styleMasterFallbackModes to derive raw plus the current default mode. Introduces isStyleMasterEnabled and styleMasterOffPreferences to centralize master-toggle state. Updates default-mode changes to recompute fallback modes when the master switch is off. Adds rollbackDefaultAndEnabledChange plus a set-comparison helper for off-state rollbacks. +43/-0    Style.tsx Use shared helpers for Style page state                                    openless-all/app/src/pages/Style.tsx Switches master-toggle and default-selection logic to shared style preference helpers. Persists full settings when default mode changes while master is off, keeping enabledModes in sync. Replaces direct enabledModes.length checks with semantic master-enabled detection. Updates the master-off save path to keep raw and the current default mode. +13/-6
Tests	stylePrefs.test.ts Extend style preference regression tests                                  openless-all/app/src/lib/stylePrefs.test.ts Adds assertions for master-off fallback modes and master-enabled detection. Covers the raw default edge case so fallback mode lists are not duplicated. Verifies default changes while master is off recompute enabledModes correctly. Adds rollback coverage for failed off-state default updates. +55/-0

---

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit 6341f19)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 312 - PR Code Verified Compliant requirements: Uses raw plus the current defaultMode when the master toggle is turned off. Keeps the UI state and persisted settings aligned through shared style preference helpers. Adds regression tests covering master-toggle-off behavior and rollback. Requires further human verification: Confirm coordinator.rs behaves correctly with persisted enabledModes of ['raw', defaultMode] in all runtime paths.

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[github-actions]

Persistent review updated to latest commit 6341f19