Skip to content

Fix/revert windows capsule qa acrylic#496

Merged
appergb merged 9 commits into
Open-Less:betafrom
HKLHaoBin:fix/revert-windows-capsule-qa-acrylic
May 19, 2026
Merged

Fix/revert windows capsule qa acrylic#496
appergb merged 9 commits into
Open-Less:betafrom
HKLHaoBin:fix/revert-windows-capsule-qa-acrylic

Conversation

@HKLHaoBin
Copy link
Copy Markdown
Contributor

@HKLHaoBin HKLHaoBin commented May 18, 2026

摘要

Fixes #487

fix(windows): 移除胶囊与 QA 浮窗的整窗 Acrylic 黑边

这个 PR 只解决一个问题:Windows 上 capsuleqa 宿主窗口套用了整窗 Acrylic,导致透明宿主被染成明显的深色矩形,录音胶囊和 QA 浮窗外侧出现大块黑边。本次改动回退这两处 Acrylic,仅保留原有的透明宿主 + 前端白色可见内容层。

修复 / 新增 / 改进

  • 移除 Windows 启动阶段对 capsule 窗口的 apply_acrylic(...)
  • 移除 Windows 启动阶段对 qa 窗口的 apply_acrylic(...)
  • 保持胶囊与 QA 浮窗原有的定位、显示、隐藏与生命周期逻辑不变
  • 保持主窗口 main 的 Mica 路径不变,不扩大这次修复范围

兼容

  • 不包含:

  • 不调整 capsule / qa 的尺寸、阴影 inset、动画、焦点策略或主窗口材质方案

  • 不处理 windows-ui-config.test.mjs 里现存的主窗口旧断言漂移问题

  • 对现有用户 / 本地环境 / 构建流程的影响:

  • Windows 下胶囊和 QA 浮窗将不再使用整窗 Acrylic,避免出现整块深色宿主矩形

  • 现有前端白色 pill / 白色 QA 卡片样式保持不变

  • 不引入新的配置项、依赖或构建步骤变更

测试计划

  • 命令:node openless-all/app/scripts/windows-ui-config.test.mjs

  • 结果:确认本次改动未影响既有窗口配置与胶囊几何相关契约;如失败,单独记录当前已知的主窗口旧断言漂移,不作为本 PR 阻塞项

  • 证据路径:openless-all/app/scripts/windows-ui-config.test.mjs

  • 命令:Windows 本机启动应用,触发录音胶囊

  • 结果:胶囊外围不再出现整块深色矩形,仅保留白色圆角 pill

  • 证据路径:录屏 / 截图,重点对比浅色背景下的胶囊宿主边界

  • 命令:Windows 本机打开 QA 浮窗

  • 结果:QA 浮窗不再出现整块深色宿主底;允许轻微透桌面作为当前可接受 trade-off

  • 证据路径:录屏 / 截图,重点查看卡片外侧是否仍有整窗染色

HKLHaoBin and others added 9 commits May 15, 2026 18:17
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Reverts the apply_acrylic blocks from Open-Less#487. Full-window Acrylic
tinted the 220×84 capsule hitbox, causing a visible dark rectangle
around the pill on light backgrounds.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

487 - Partially compliant

Compliant requirements:

  • macOS 路径保持不变

Non-compliant requirements:

  • capsuleqa 窗口补上 Windows Acrylic 兜底
  • Acrylic 仅在 Windows 下启用并改善透明可读性
  • Acrylic 失败仅记录 warning、不影响启动
  • 解决 Windows 上 capsule / qa 近乎完全透明的问题

Requires further human verification:

  • 需要在 Windows 10 / Windows 11 实机上确认窗口可读性与视觉效果是否符合预期
  • 需要在 macOS 上回归验证窗口表现未被意外影响
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@HKLHaoBin
Copy link
Copy Markdown
Contributor Author

PixPin_2026-05-18_23-09-57

@HKLHaoBin
Copy link
Copy Markdown
Contributor Author

目前正在测试回退该提交后的构建效果,需要等我测试构建完成后,再决定是否合并这个 PR。

@HKLHaoBin
Copy link
Copy Markdown
Contributor Author

HKLHaoBin commented May 18, 2026

PixPin_2026-05-18_23-24-23

测试结果说明本次修改可以解决该问题,建议合并。

@Cooper-X-Oak
Copy link
Copy Markdown
Contributor

Cooper-X-Oak commented May 18, 2026

Update: ignore my previous fork-followup route. We decided not to route this through HKLHaoBin/openless#1 because that adds unnecessary coordination overhead.

The clean upstream path is now the reopened direct PR:

#497

#497 carries the same intended fix on top of latest beta without going through this PR's source branch: keep the capsule host transparent, keep QA Acrylic intact, make the Windows capsule pill own its stable DOM surface, and add a focused contract test.

@appergb appergb merged commit 94fe8c7 into Open-Less:beta May 19, 2026
4 checks passed
@HKLHaoBin HKLHaoBin deleted the fix/revert-windows-capsule-qa-acrylic branch May 19, 2026 06:48
appergb pushed a commit that referenced this pull request May 19, 2026
…crylic 回退

回退 #487 引入的 Windows capsule/QA 浮窗 apply_acrylic 调用 (PR #496),
解决浅色背景下 220×84 胶囊出现深色矩形的视觉 bug。
本次只动版本号,不携带其他逻辑改动。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants