Fix Sherpa local ASR state sync#523
Open
weikeyi wants to merge 2 commits into
Open
Conversation
PR Reviewer Guide 🔍(Review updated until commit cd9696d)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit cd9696d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
摘要
tokenizer/目录校验和downloadedBytes统计。beta解决设置页重构冲突:旧 Settings.tsx 不再进入本 PR,新版 settings/ProvidersSection.tsx 中已包含sherpa-onnx-local的本地 provider 识别逻辑。验证
git diff --check upstream/beta...HEAD✅cargo check --manifest-path openless-all/app/src-tauri/Cargo.toml✅npm run build✅cargo test --manifest-path openless-all/app/src-tauri/Cargo.toml sherpa --lib -- --nocapture✅cargo test --manifest-path openless-all/app/src-tauri/Cargo.toml persist_settings --lib -- --nocapture✅PR Type
Bug fix, Enhancement, Tests
Description
Sync active ASR provider on save/startup
Verify extracted Sherpa assets and bytes
Refresh credentials on provider changes
Expand deletion logic and API typings
Diagram Walkthrough
File Walkthrough
4 files
Treat tokenizer as a directory assetTrack Sherpa cache and download bytesAdd credentials vault provider sync helpersUpdate Sherpa API shapes and mocks5 files
Verify archives and count extracted bytesSync active ASR provider during saveRestore provider state during startupAllow deleting partial Sherpa downloadsRefresh credentials after provider changes