fix(ui): 本会话内延后提供商配置提示#68
Merged
appergb merged 1 commit intoApr 30, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the provider setup reminder so that deferring the prompt is tracked only for the current session via sessionStorage, instead of persisting a "seen" state in localStorage, and refreshes the associated key name and test wording accordingly. Sequence diagram for provider setup prompt using sessionStoragesequenceDiagram
actor User
participant App
participant FloatingShellBody
participant CredentialStore
participant SessionStorage
participant ProviderSetup
User->>App: Launch app
App->>FloatingShellBody: Mount component
FloatingShellBody->>CredentialStore: getCredentials()
CredentialStore-->>FloatingShellBody: CredentialsStatus
FloatingShellBody->>SessionStorage: getItem(PROVIDER_SETUP_PROMPT_DEFERRED_KEY)
SessionStorage-->>FloatingShellBody: promptDeferredValue
FloatingShellBody->>ProviderSetup: shouldShowProviderSetupPrompt(credentials, promptDeferredValue)
ProviderSetup-->>FloatingShellBody: boolean
alt Prompt should be shown
FloatingShellBody-->>User: Show provider setup prompt
User->>FloatingShellBody: Click defer button
FloatingShellBody->>SessionStorage: setItem(PROVIDER_SETUP_PROMPT_DEFERRED_KEY, 1)
FloatingShellBody-->>User: Close prompt
else Prompt should not be shown
FloatingShellBody-->>User: No provider prompt this session
end
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the storage key has been renamed and moved from localStorage to sessionStorage, consider cleaning up the old
ol.providerSetupPromptSeenentry (e.g., on first run after upgrade) to avoid leaving stale keys around in existing installations.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the storage key has been renamed and moved from localStorage to sessionStorage, consider cleaning up the old `ol.providerSetupPromptSeen` entry (e.g., on first run after upgrade) to avoid leaving stale keys around in existing installations.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
appergb
pushed a commit
that referenced
this pull request
Apr 30, 2026
包含本轮所有合并: - Codex 终审两条 HIGH (cancel race) 修复 (PR #79) - 6 个 Cooper-X-Oak/Codex bot PRs 自动合并 (#44 #49 #53 #68 #72 #73) - 2 个有冲突 PR 本地 rebase 后合并 (#66 cancel + 空转写并存 / #67 Windows docs) - README 破图修复 (PR #80) - workflow-scope 受限的 #48 + #75 由用户在 GitHub UI 直接合并 3 处版本字段同步:package.json + tauri.conf.json + Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
关联 fork 验证:Cooper-X-Oak#12。
本 PR 是从 fork/dev 已验证批次拆出的 UI 状态修复:提供商配置提示不再用 localStorage 永久记住“已看过”,而是只在本 session 内延后,避免用户未完成配置后后续启动再也不提示。
fork/dev 先行验证
b9ee8b8。修复 / 新增 / 改进
PROVIDER_SETUP_PROMPT_SEEN_KEY改为PROVIDER_SETUP_PROMPT_DEFERRED_KEY。localStorage改为sessionStorage。兼容
测试计划
npm run buildgit diff --checknode --loader ts-node/esm src/lib/providerSetup.test.tsts-node。Summary by Sourcery
Limit provider setup prompts to be deferred only within the current session instead of being permanently suppressed.
Enhancements: