Skip to content

fix(asr): 删除 retranscribe 里重复的 ElevenLabs 匹配分支 - #906

Merged
H-Chris233 merged 1 commit into
Open-Less:betafrom
bigsongeth:fix/dup-elevenlabs-match-arm
Aug 5, 2026
Merged

fix(asr): 删除 retranscribe 里重复的 ElevenLabs 匹配分支#906
H-Chris233 merged 1 commit into
Open-Less:betafrom
bigsongeth:fix/dup-elevenlabs-match-arm

Conversation

@bigsongeth

@bigsongeth bigsongeth commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

User description

问题

coordinator.rs 的 retranscribe 路径里,ActiveAsr::ElevenLabs(e) => { ... } 连续出现了两次,两个分支逐字节相同。第二条永远走不到,cargo check 会报:

warning: unreachable pattern
    --> src/coordinator.rs:2157:13
     |
2151 |             ActiveAsr::ElevenLabs(e) => {
     |             ------------------------ matches all the relevant values

引入于 8a2febf#851),此后一直在 beta 上。

改动

删掉重复的第二条分支,共 6 行。纯死代码清理,无行为变化。

验证

修复后 cargo check 通过,unreachable pattern 警告数为 0。

🤖 Generated with Claude Code


PR Type

Bug fix


Description

  • Remove duplicate ElevenLabs retranscribe match branch.

  • Eliminates unreachable pattern compiler warning.

  • Pure dead code cleanup with no behavior change.


File Walkthrough

Relevant files
Bug fix
coordinator.rs
Remove duplicate ElevenLabs transcribe match arm                 

openless-all/app/src-tauri/src/coordinator.rs

  • Deletes the second identical ActiveAsr::ElevenLabs match arm in the
    retranscribe path.
  • Removes the unreachable pattern warning reported by cargo check.
  • Introduces no functional changes; the first branch already handled the
    case.
+0/-6     

该分支与上一条完全一致,属于死代码,cargo check 会报
warning: unreachable pattern。

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

**🎫 Ticket compliance analysis **

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@H-Chris233
H-Chris233 merged commit 9dbb316 into Open-Less:beta Aug 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants