fix(asr): 删除 retranscribe 里重复的 ElevenLabs 匹配分支 - #906
Merged
H-Chris233 merged 1 commit intoAug 5, 2026
Conversation
该分支与上一条完全一致,属于死代码,cargo check 会报 warning: unreachable pattern。 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
问题
coordinator.rs的 retranscribe 路径里,ActiveAsr::ElevenLabs(e) => { ... }连续出现了两次,两个分支逐字节相同。第二条永远走不到,cargo check会报:引入于 8a2febf(#851),此后一直在
beta上。改动
删掉重复的第二条分支,共 6 行。纯死代码清理,无行为变化。
验证
修复后
cargo check通过,unreachable pattern警告数为 0。🤖 Generated with Claude Code
PR Type
Bug fix
Description
Remove duplicate ElevenLabs retranscribe match branch.
Eliminates unreachable pattern compiler warning.
Pure dead code cleanup with no behavior change.
File Walkthrough
coordinator.rs
Remove duplicate ElevenLabs transcribe match armopenless-all/app/src-tauri/src/coordinator.rs
ActiveAsr::ElevenLabsmatch arm in theretranscribe path.
unreachable patternwarning reported bycargo check.case.