Reorder SharedView __init__ params #2905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReimarBauer
approved these changes
Oct 11, 2025
Member
ReimarBauer
left a comment
ReimarBauer
left a comment
There was a problem hiding this comment.
file_manager needs not a change because it used the parameters by keywords.
Member
|
we should enable in testing-all-oses.yml and lint.yml the new branch, all which starts with prepare** too, similar to the GSOC branches. Please add this to the PR too |
Collaborator
Author
ok |
ReimarBauer
merged commit cc3b7ec
into
Open-MSS:prepare_merge_to_develop_from_GSOC2025-AnnapurnaGupta
7 of 10 checks passed
ReimarBauer
pushed a commit
that referenced
this pull request
Jan 2, 2026
* Reorder SharedView __init__ params * Enable CI for prepare** branches
annapurna-gupta
added a commit
to annapurna-gupta/MSS
that referenced
this pull request
Jan 3, 2026
* Reorder SharedView __init__ params * Enable CI for prepare** branches
ReimarBauer
pushed a commit
that referenced
this pull request
Jan 6, 2026
* Reorder SharedView __init__ params * Enable CI for prepare** branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #2898