Skip to content

fix: mixed up logic around response mediatype addition/removal #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joschi merged 1 commit into from
Feb 28, 2022
Merged

fix: mixed up logic around response mediatype addition/removal #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: adding response media type is breaking
  • Loading branch information
@slinstaedt
slinstaedt committed Jan 27, 2022
commit 4c530db082cf40faf33c72fea2e352e7b9c04fad
2 changes: 1 addition & 1 deletion core/src/main/java/org/openapitools/openapidiff/core/model/ChangedContent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public DiffResult isCoreChanged() {
if (increased.isEmpty() && missing.isEmpty()) {
return DiffResult.NO_CHANGES;
}
if (context.isRequest() && missing.isEmpty() || context.isResponse() && increased.isEmpty()) {
if (context.isRequest() && missing.isEmpty() || context.isResponse() && missing.isEmpty()) {
return DiffResult.COMPATIBLE;
}
return DiffResult.INCOMPATIBLE;
Expand Down
4 changes: 2 additions & 2 deletions core/src/test/java/org/openapitools/openapidiff/core/ContentDiffTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ public void testAddedResponseContentTypeDiff() {
ChangedOpenApi changedOpenApi =
OpenApiCompare.fromLocations(
"content_type_response_add_1.yaml", "content_type_response_add_2.yaml");
assertThat(changedOpenApi.isCompatible()).isFalse();
assertThat(changedOpenApi.isCompatible()).isTrue();
}

@Test
public void testRemovedResponseContentTypeDiff() {
ChangedOpenApi changedOpenApi =
OpenApiCompare.fromLocations(
"content_type_response_add_2.yaml", "content_type_response_add_1.yaml");
assertThat(changedOpenApi.isCompatible()).isTrue();
assertThat(changedOpenApi.isCompatible()).isFalse();
}

@Test
Expand Down