PHP Client does not handle default values correctly when they are ENUM references

[soundstripe]

The default values set in the constructor for PHP Model classes does not correctly reference self::.

I believe the offending code is this line:

openapi-generator/modules/openapi-generator/src/main/resources/php/model_generic.mustache

Line 164 in d9a6f4d

$this->container['{{name}}'] = isset($data['{{name}}']) ? $data['{{name}}'] : {{#defaultValue}}{{{defaultValue}}}{{/defaultValue}}{{^defaultValue}}null{{/defaultValue}};

example generated code:

        $this->container['code'] = isset($data['code']) ? $data['code'] : CODE_200;

expected:

        $this->container['code'] = isset($data['code']) ? $data['code'] : self::CODE_200;

[soundstripe]

Looks like this applies only to numeric values. The following change to line 164 seems to fix it for me:

        $this->container['{{name}}'] = isset($data['{{name}}']) ? $data['{{name}}'] : {{#defaultValue}}{{#isEnum}}{{#isNumeric}}self::{{/isNumeric}}{{/isEnum}}{{{defaultValue}}}{{/defaultValue}}{{^defaultValue}}null{{/defaultValue}};

[soundstripe]

The fact that string default values are not referencing the defined enums (instead being passed through the template as literals) was disturbing so I traced that further.... may be a problem here:

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java

Line 5296 in 6a61910

if ("string".equalsIgnoreCase(dataType)) {

[wing328]

Agreed

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java

Line 5296 in 6a61910

if ("string".equalsIgnoreCase(dataType)) {

may be a problem. Thanks for the trace.

Looks like this applies only to numeric values. The following change to line 164 seems to fix it for me:

Can you please file a PR with the suggested fix?