[BUG] [Typescript-Axios] Sets are treated like Arrays

[Thornsnake]

Description

When creating Typescript code of the EVE Online API (https://esi.evetech.net/_latest/swagger.json) the generated code contains Set objects that are treated like Array objects. The code attempts to use Set<>.join() on Sets and tries to JSON.stringify(Set<>) them. Those are things that would only work on Arrays.

openapi-generator version

5.0.0 Beta

Command line used for generation

java -jar openapi-generator-cli-5.0.0-beta.jar generate -i https://esi.evetech.net/_latest/swagger.json -g typescript-axios -o api

Steps to reproduce

Execute the command and the resulting api.ts file will contain the broken code.

The code to look for is labels.join(COLLECTION_FORMATS.csv) and JSON.stringify(itemIds !== undefined ? itemIds : {}).

Suggest a fix/enhancement

I fixed these bugs by wrapping all Set objects into Array.from(Set<>).

For example:
Array.from(labels).join(COLLECTION_FORMATS.csv);
JSON.stringify(itemIds !== undefined ? Array.from(itemIds) : {})

The generated code should either use Arrays to begin with or (if the elements need to be unique) the Set needs to be turned back into an Array, before Array methods are called on it.

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[rvowles]

and the second ternary option needs to be an empty array ideally. Not an object.

[rvowles]

(I'm fixing this in my variant)

[Thornsnake]

@Thornsnake are you sure you are using the Typescript AXIOS client? It doesn't generate sets.

I am using the command with the parameter -g typescript-axios.
I think that should be the correct one, but this was my first time using this generator, so I might have made a mistake somewhere.

I executed the whole command (java -jar openapi-generator-cli-5.0.0-beta.jar generate -i https://esi.evetech.net/_latest/swagger.json -g typescript-axios -o api) again to double check, but it definitely seems to generate Sets for me.

https://i.imgur.com/piUbb9z.png

[rvowles]

Yes, its a new feature of 5.0. I have fixed it in my attempt to fix it: https://github.com/rvowles/openapi3-typescript-axios

…

On Thu, Jul 23, 2020 at 4:06 AM Thornsnake ***@***.***> wrote: @Thornsnake <https://github.com/Thornsnake> are you sure you are using the Typescript AXIOS client? It doesn't generate sets. I am using the command with the parameter *-g typescript-axios*. I think that should be the correct one, but this was my first time using this generator, so I might have made a mistake somewhere. I executed the whole command (java -jar openapi-generator-cli-5.0.0-beta.jar generate -i https://esi.evetech.net/_latest/swagger.json -g typescript-axios -o api) again to double check, but it definitely seems to generate Sets for me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6904 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAANTWCW7HUL3XCTKMNIG2DR44E7XANCNFSM4OV67JNA> .

-- --- Richard Vowles, Full stack - from Kubernetes, through Node & Java, Web and Mobile development in Flutter - software developer for hire! ph: +64275467747

[macjohnny]

so this is related to #6931?

would you like to fix it?

[rvowles]

I have already delt with Sets in the above repo, the serialisation and deserialisation into sets is actually a bit more complex than just making them primitive types.