Skip to content

[Golang][client] fix go import issue#1083

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
anandshah05:master
Sep 29, 2018
Merged

[Golang][client] fix go import issue#1083
wing328 merged 1 commit into
OpenAPITools:masterfrom
anandshah05:master

Conversation

@anandshah05

Copy link
Copy Markdown
Contributor

PR checklist

Adding optional import for non primitive fields

Description of the PR

#1082

@wing328

wing328 commented Sep 24, 2018

Copy link
Copy Markdown
Member

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328

wing328 commented Sep 24, 2018

Copy link
Copy Markdown
Member

cc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07)

@anandshah05 anandshah05 changed the title fix go import issue [Golang][client] fix go import issue Sep 27, 2018
@anandshah05

Copy link
Copy Markdown
Contributor Author

Please merge

@wing328

wing328 commented Sep 29, 2018

Copy link
Copy Markdown
Member

@anandshah05 I did some tests locally and it's adding the following for the test spec you provided:

@@ -16,6 +16,7 @@ import (
        "net/url"
        "strings"
        "fmt"
+       "github.com/antihax/optional"
 )

I'm ok with the change.

@wing328 wing328 merged commit 3a71e59 into OpenAPITools:master Sep 29, 2018
@anandshah05

Copy link
Copy Markdown
Contributor Author

Thank you!

@wing328 wing328 added this to the 3.3.0 milestone Oct 1, 2018
@wing328

wing328 commented Oct 2, 2018

Copy link
Copy Markdown
Member

@anandshah05 thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants