Skip to content

python-experimental adds DecimalSchema#11282

Merged
spacether merged 7 commits into
OpenAPITools:masterfrom
spacether:feat_pythonExp_adds_Decimal
Jan 12, 2022
Merged

python-experimental adds DecimalSchema#11282
spacether merged 7 commits into
OpenAPITools:masterfrom
spacether:feat_pythonExp_adds_Decimal

Conversation

@spacether

@spacether spacether commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

python-experimental adds DecimalSchema (type: string format: number)

  • DecimalSchema allows user to send number amounts as strings to preserve the desired sig figs.
  • I also added isDecimal to CodegenModel; this was needed to get the feature working
  • Decimal changed to decimal.Decimal in case someone creates a component named Decimal
  • An import path in model tests was fixed for python-experimental
  • The __new__ methods for models now returns ModelName so pycharm type hints will show instance properties on instances created with inst = ModelName({})

Note: for DecimalSchemas like these, one could also define string validations like a regex that requires a specific number of sig figs.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether marked this pull request as draft January 11, 2022 20:06
@spacether spacether marked this pull request as ready for review January 12, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant