fix #13150 Add uniqueModelMappings option - #13802
Closed
bernie-schelberg-mywave wants to merge 1 commit into
Closed
Conversation
arandth
reviewed
Oct 24, 2022
arandth
left a comment
There was a problem hiding this comment.
To be honost: I don't see why we should need a new option for this. If this behavior is considered to be a bug, then it should be corrected without the need to set an new option.
Contributor
Author
|
@arandth I'm happy to submit another that just fixes the issue, and doesn't add a new option, please advise if this is preferred. |
Contributor
Author
|
I opened another pull request which treats this issue as a bug and doesn't add the new configuration option: #13815. I'm happy to close this one if the other is preferred. |
Contributor
Author
|
Closing this one as the consensus seems to be that this is indeed a bug, and doesn't need another option to enable or disable the behaviour. Refer to #13815 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having multiple names for a model mapping can cause issues with clients that are expecting a particular types to always have the same model name. Refer #13150. Since this potentially breaks system that rely on having the class names work as mappings alongside custom discriminator values, a new configuration option has been added -
uniqueModelMappings(defaults tofalse).PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)