Skip to content

fix #13150 Add uniqueModelMappings option - #13802

Closed
bernie-schelberg-mywave wants to merge 1 commit into
OpenAPITools:masterfrom
bernie-schelberg-mywave:issue13150
Closed

fix #13150 Add uniqueModelMappings option#13802
bernie-schelberg-mywave wants to merge 1 commit into
OpenAPITools:masterfrom
bernie-schelberg-mywave:issue13150

Conversation

@bernie-schelberg-mywave

Copy link
Copy Markdown
Contributor

Having multiple names for a model mapping can cause issues with clients that are expecting a particular types to always have the same model name. Refer #13150. Since this potentially breaks system that rely on having the class names work as mappings alongside custom discriminator values, a new configuration option has been added - uniqueModelMappings (defaults to false).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@arandth arandth left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honost: I don't see why we should need a new option for this. If this behavior is considered to be a bug, then it should be corrected without the need to set an new option.

@bernie-schelberg-mywave

Copy link
Copy Markdown
Contributor Author

@arandth I'm happy to submit another that just fixes the issue, and doesn't add a new option, please advise if this is preferred.

@bernie-schelberg-mywave

Copy link
Copy Markdown
Contributor Author

I opened another pull request which treats this issue as a bug and doesn't add the new configuration option: #13815. I'm happy to close this one if the other is preferred.

@bernie-schelberg-mywave

Copy link
Copy Markdown
Contributor Author

Closing this one as the consensus seems to be that this is indeed a bug, and doesn't need another option to enable or disable the behaviour. Refer to #13815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants