Remove @JsonTypeName from jersey2 POJOs - #14854
Open
bernie-schelberg-mywave wants to merge 1 commit into
Open
Conversation
This was referenced Mar 2, 2023
Member
|
I remember this is needed to fix an issue. can you use |
Contributor
Author
|
@wing328 actually, it was a step on a round-about way to fixing the issue with dart generation with mapped discriminator models. I believe you fixed that differently in this one: #14984. I still think that having To answer your question, though, I believe it was added here: #6995. I'm still not clear on why the change was necessary, as the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sibling PR to #14842 and #14852. This PR removes the
@JsonTypeNameannotation from the jersey2 templates. I want to make some other changes that affect the handling of the@JsonTypeNameannotation, and investigating those issues led to the conclusion that@JsonTypeNameis unnecessary, as the name of the type is specified in the super class'@JsonSubTypesannotation wherever necessary.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)