Skip to content

[Java] [Microprofile] Remove unused CXF dependency#15364

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
zUniQueX:java-microprofile-remove-cxf
May 2, 2023
Merged

[Java] [Microprofile] Remove unused CXF dependency#15364
wing328 merged 1 commit into
OpenAPITools:masterfrom
zUniQueX:java-microprofile-remove-cxf

Conversation

@zUniQueX

Copy link
Copy Markdown
Contributor

Follow-up for #6680.
Using the microprofile library requires an additional (unnecessary) dependency in a project. If one uses a different implementation than CXF, e.g. Jersey, the CXF dependency has to be pulled in additionally. But Jersey has an own implementation for multipart handling.

The dependency and the corresponding import aren't used at the moment. Thus, they can be safely deleted.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@wing328

wing328 commented May 2, 2023

Copy link
Copy Markdown
Member

thanks for the PR. let's give it a try

@wing328 wing328 merged commit 6686fb8 into OpenAPITools:master May 2, 2023
@miguelborges99

Copy link
Copy Markdown
Contributor

The PR #15364 has broken master branch

wing328 added a commit that referenced this pull request May 3, 2023
wing328 added a commit that referenced this pull request May 3, 2023
@wing328

wing328 commented May 3, 2023

Copy link
Copy Markdown
Member

@miguelborges99 noticed that too. reverted the change via #15392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants