Skip to content

[kotlin-sever][jaxrs-spec] Fix default value, add nullable support#16265

Merged
wing328 merged 1 commit into
masterfrom
14413-followup
Aug 6, 2023
Merged

[kotlin-sever][jaxrs-spec] Fix default value, add nullable support#16265
wing328 merged 1 commit into
masterfrom
14413-followup

Conversation

@wing328

@wing328 wing328 commented Aug 6, 2023

Copy link
Copy Markdown
Member
  • Fix default value
  • add nullable support
  • add tests

a follow-up PR to #14413

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

@wing328

wing328 commented Aug 6, 2023

Copy link
Copy Markdown
Member Author

Just merged this as I've other PRs for kotlin generators. If anyone has any question/feedback on this PR, happy to address it later.

@stephan-strate

Copy link
Copy Markdown
Contributor

The removal of the " around the default value seems to cause problems with values other than string. As far as I know, the default value does only support string values. So for example integers or enums need to be passed as string as well. With this change, it is not compilable anymore.

The pull requests states "Fix default value". Can you elaborate on this?

@wing328

wing328 commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

@stephan-strate thanks for upgrading to v7.0.0 and reporting the issue. I wonder if you can open an issue to track this regression and provide a minimal spec to reproduce the problem.

I'll try to look into it later this week.

@stephan-strate

Copy link
Copy Markdown
Contributor

Created issue #16455, will provide pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants